[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v1] xen/arm: vGICv3: Restore the interrupt state correctly
- To: Ayan Kumar Halder <ayankuma@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 28 Oct 2022 08:54:58 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D2dt6MnFf+F1uP31ARA4eip6dwxpSBhrJnRCvCW9atA=; b=WN0HrPiUndwUKzVGK0GMwKHOhwK1fZE47L9OwZPWnyDfnTFj9f7xSz8pJH1WzXlVGDGQpYHByp0rMnv+dMGySjlPpUqVeDOaO/i3w30f6wosJneuIFy77wGq460CNLSSu0yk22UpdNGRe8UK7Lkh6Wifsoh1SgqUTJYLMeaWdkFhY4U+Xwtu0B1kIic9lqyiHWX8SPyTP+uiKhsu/nLSwomhzFkHg8z3PBoYp3dAU418dgHzUDnZIJxnM7w5uGm0CxSYx4Q5sEoTakegyoO79DS46D7d/1c6Yg7nU3jTVc7bYspB/8BPTAExH+87/+voTUsEHY7WNccnHtK5lOyjFw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D2dt6MnFf+F1uP31ARA4eip6dwxpSBhrJnRCvCW9atA=; b=kpFrVgO40CFXtFfotGDu6bxaYNF2Bh5u/eZ2Aq//US6NJqp6fnIk+axibpKbOY/YTvHRHmItNtnZangbCy2HbgBeP4jn2vzFeYItH8UuqGjOGbV3zNW7Lju7+Usnrn60K9ZnDPfiy24NJM2FSMJpFk88qZMzoKzKQOaMIiBylVgNjnnQ+2n0QGp8wl+lXTcCVkd1kTUYHZhUQNAwuMztlMYIgDoIP/iTaDF/QZ6EYHQv7+0DpdIdyBlSfcEK+LPmDJrLKlEw/CbpvvKgKAsvwf7BL6pbewZW/3meuYQatnmjbU9keY7vtKtgpKFUQeYN6Q+niyOV/qrdEAcqP+3jew==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TqkW9XW1VP1Ttm3hv6OU7lreqBhJsyxyQKVj3BpEi4I2Tm9nig9O2nMo3ohL1ZwdZNJ0QCnjG9UujvOA6skf2e/Z/TI5JT80y3368KpTp/EZpMeCjcIesmJ6QcSGLLUZ8d1aFRZGqKpC7agfOx7pMECA0QsRQ4T60AuZyq1ZsHjRNePWZfoZexQCp3yU5ROoAuOMJwGgqlHzdd9w7c4dgrd7cMDbbEdb8a/R8MDfL9KMVG9g/hTodaH5HR3sq2LGP3IZ9clHJmG3Oba3NJIDXpskCWkuV05uQTcQpjqbAgYFa2Z7LgtB8TJJ2dwFsTZkUhBAuM03LRhwzBf1dN/kxA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RAk/CDKyeqkBCdYfsPPj2sGU6alrrpeeTro+2smbIMRAjlES/yMiF6q3uqrjIxU+xfxCopf+W4OyzKnDSysX7NZM4WYMj/j57rMlFYTdGV0Xh7YJbyPC+m1UI1IqkjUuNXUyOSc3vrRYVSMVCw84JDVlsLOc5ZZ3umEJsPhXlZaahQTXNFBY5Bh7bRYQr4kL3NpTezrBUOOOzbHjd7FXUgzhepdajCkJf14vqL26EmYs4doB5LMAJ25i5Tsb1INhui6acTMylDXmYyhUaSdbqQKDQX5LnvmMDT0p1XS+WgKhXvjXeunyndFlta0XdL6Yd+BmHWn03bdrjoDntz8ozw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "stefanos@xxxxxxxxxx" <stefanos@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Fri, 28 Oct 2022 08:55:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY6jesKd0lAUK8nUWE7dUi6/OJ1K4jgXoA
- Thread-topic: [XEN v1] xen/arm: vGICv3: Restore the interrupt state correctly
Hi Ayan,
> On 27 Oct 2022, at 20:09, Ayan Kumar Halder <ayankuma@xxxxxxx> wrote:
>
> As "spin_lock_irqsave(&v->arch.vgic.lock, flags)" saves the current interrupt
> state in "flags", "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)" should
> be
> used to restore the saved interrupt state.
>
> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and
> property tables")
> Signed-off-by: Ayan Kumar Halder <ayankuma@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
This is definitely a bug fix candidate for 4.17 !!
Cheers
Bertrand
> ---
> xen/arch/arm/vgic-v3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index d0e265634e..015446be17 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -582,7 +582,7 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v,
> mmio_info_t *info,
> write_atomic(&v->arch.vgic.rdist_pendbase, reg);
> }
>
> - spin_unlock_irqrestore(&v->arch.vgic.lock, false);
> + spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
>
> return 1;
> }
> --
> 2.17.1
>
|
