[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[for-4.17] Re: [XEN v1] xen/arm: vGICv3: Restore the interrupt state correctly



Hi,

On 27/10/2022 21:53, Andre Przywara wrote:
On Thu, 27 Oct 2022 20:09:13 +0100
Ayan Kumar Halder <ayankuma@xxxxxxx> wrote:

Hi,

As "spin_lock_irqsave(&v->arch.vgic.lock, flags)" saves the current interrupt
state in "flags", "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)" should be
used to restore the saved interrupt state.

Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and property 
tables")
Signed-off-by: Ayan Kumar Halder <ayankuma@xxxxxxx>

Thanks for fixing this!

Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Henry, this is fixing a bug in the ITS. The feature is at the moment experiement and the code is not used by other subystem, so technically not necessary for 4.17. But if you still accept any bug fix (I know we are close to the release), then I would like to request to include. It should be risk free.

Cheers,

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.