[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v2 01/12] xen/Arm: vGICv3: Sysreg emulation is applicable for Aarch64 only
- To: Ayan Kumar Halder <ayankuma@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Mon, 31 Oct 2022 18:43:47 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lvy+G2kZybtD5104OadHck5HK/nEkBIFHuU9n9YksSI=; b=Hfn8CS3P7aus9hmqsMaIIAaWKZ/7Y6SHI1GgO9spWg9XD35bdy3/AWEPH14ed9N4KSKqEgkLUCzbnpqFk05Pa1eGTx7CRCtnGEjzcWFfxmr68GSqRCcA93B2xq3tCaJdzHIJ0T+fvsPg3IzuhRXujhoUMKhvw9dyD18tS67qZbbI3BHv9sba3CX2IcNx6ojNUaMQmuaIBrpyE1jz8x/FnfMFuTPn38CvIVYymWPkM1ricOMR8MaJyCNjUup52DDc82W4wz9XA5qO1ZG1O5XwWrWzURjv1TPuUJ3LThT2IC5clxLLWCO9RKMaTL61lyKwoX9BFcYDmGtINMPakJPeRQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hjh+I5o8RhbtTJtdo0EtR5/FTmasSLgLSTtCfAlLrczMg3e9opMSxlNBz/6HdIQ/BWBuhcr9rK91+cJ6n9dIFVWud8yb7/+wHjjGxIjKn8A/1tWWexpUIrLLsrrZirpTb9Q1+YI+AQGxMuZy00/See+1KtX9Ein7SrMnRUSuxxR48fP3S14EhqfoP2B3waYhWVzYu3zjeOAIm/RLULWeBZssv6SnbtQb9L7s+BGTitH/7aST3M2Tl+TId6UjneySQpK1Zau23efuWFhTnMhDjopMmctiz4+QgxejrodNQtlttgp9fZf+PsyTowWxxaQsK5H9JR+cpjXvtWE4DcPKYQ==
- Cc: <sstabellini@xxxxxxxxxx>, <stefanos@xxxxxxxxxx>, <julien@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <bertrand.marquis@xxxxxxx>, <burzalodowa@xxxxxxxxx>
- Delivery-date: Mon, 31 Oct 2022 17:44:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Ayan,
On 31/10/2022 16:13, Ayan Kumar Halder wrote:
>
>
> Refer ARM DDI 0487G.b ID072021, EC==0b011000 is supported for Aarch64 state
I think when adding new code we should be taking the latest spec (which is I.a)
as a base +
you are lacking the information \wrt page number, table, whatever contains this
information
within ARM ARM.
Apart from that, wouldn't it be easier for those reading the commit to just
write e.g.:
"Sysreg emulation is 64-bit specific, so guard the calls to
vgic_v3_emulate_sysreg
as well as the function itself with #ifdef CONFIG_ARM_64."
Placing EC code in such statement is not very helpful.
~Michal
|
