[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH-for-4.17 v3] xen/sched: migrate timers to correct cpus after suspend
- To: Dario Faggioli <dfaggioli@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 4 Nov 2022 07:50:14 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7tr28D0lVckUdVYnULxk2x8HjYGl7wCoR+ujYrNYY4U=; b=jKfBMgMdFzFPrpQHlxl4nuB05xvLQrB42V1q+Z8W+RN2SGdgS0TX0pM+Mge8sO61RsS5kpXpqpgolKV5lY/VcJn2Gh+7j0k56ml5wVymQX3S5LznlrF7NsHwbcL6ew7mgVQOuq93Gx3yS9YlKv8c4QRrwBip/1d7ifrndgfldi/j05E2pRxh71S4YMSO92JXkgoA34k4zWJGRaJZL+OgwObvkaouRszj2z+GFcMf7+ygRXfT0fcE6ICbuTblM/ua0YjrquSx2aRK6kLClrSXHYx4Y1kLoscIWad6JI/zvZEf6MqHgVB1D16jXkOmZfxf0Cv6f/Njy4e+vCAFBo2ihw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7tr28D0lVckUdVYnULxk2x8HjYGl7wCoR+ujYrNYY4U=; b=dfY9kT0rPLltG1TRE9ARjzRCdIdS6oJU9dwIxtQtbCyhHDCpeJ2kihhib7K4tInxytccoH5+eU6Tmli6AILlddg36FNmgqLFxaKteuD+gMc1RT308OBttg68pxLbuWXYJWia/bM/CoS/jJbgtbfFRFBp4zs6rlr6ZIXG+NfjyDo9mNfl0nTyioPNX2vB9qmGcMCXO0Tom7hSXz1a9WAHpibTh+pclZuv9DfrL9gUu4oHVeESRVbyasQ4RJfob+rbbslgmB+gLdipL0gTot6pg2KgSt7RP/ehJp+GYlDigI8XQkI13kn7MwA/yeTRCV35rJTy2FEymd+m+J/T4H/Pzw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Zgk2x3/Ube8QIbjF8Xo4QnWHNL1W5gCs5qUyjVTevjdW8TVEKSehzLG/yuIAuFQgcHg92vONS1vXfKcvF0vFNNd8pFzwL240/VMwvZLQqLIkVKd7oOZn2BJGK4EOKembxSeDuncXMxpAQGzEyrZRWG0oItYgWC4wQ7E0PXG0LaAzlRs8L2Nw9cCHEWbVkhCRK+gSgvB+Ue5EdU4fdMJheG4ydRXf4elJDiTEso//jZbfpEky3McFMlcMW70d0t72AEALe32lZ7l1H7hpnf2PIQ1sgMDZ2SCBpCthTCabYFIl6IJC+ZJuL3W3h4LlcBSj7fXywtJMZgRwbzxC7hmsRg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dr1ioL8xCjjdjAvZDpOm5lKUiK+E8scwAd+4EiB2rVYFSGhSYnccZpsYtG3CCh6+ZPlR/GETWxm6r6VgacjUsFcvgAdK8GpR5u1KsQTywv3DtOnj9IzXGrgiw4Bzmqs4gX72a3iM59BrJ/pPVRlV87s5lQgynzniDDiajvPiOLEUZGLUNSFFMzegQTpaTPhhgnlDNfw1MnGA53hKsATPOx7tD2omuo6krF2spn2KEAGp971deAha8ZRc+aSPkzRYnyId7aO/TxicnCPnfEGoHNIxbfV2DvGyDMMXPmblxCh2qRBrwHJXi/GEScbtm6k/xkqzq+9QuFSfRYM3maJCUg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "marmarek@xxxxxxxxxxxxxxxxxxxxxx" <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "mengxu@xxxxxxxxxxxxx" <mengxu@xxxxxxxxxxxxx>
- Delivery-date: Fri, 04 Nov 2022 07:50:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY7svnH5/QyAssMEyjfYS0Wh4IB64uZiWAgAAAQXA=
- Thread-topic: [PATCH-for-4.17 v3] xen/sched: migrate timers to correct cpus after suspend
Hi Juergen,
> On Wed, 2022-11-02 at 16:00 +0100, Juergen Gross wrote:
> > Today all timers are migrated to cpu 0 when the system is being
> > suspended. They are not migrated back after resuming the system
> > again.
> >
> > This results (at least) to visible problems with the credit
> > scheduler,
> > as the timer isn't handled on the cpu it was expected to occur, which
> > will result in an ASSERT() triggering. Other more subtle problems,
> > like
> > uninterrupted elongated time slices, are probable. The least effect
> > will be worse performance on cpu 0 resulting from most scheduling
> > related timer interrupts happening there after suspend/resume.
> >
> > Add migrating the scheduling related timers of a specific cpu from
> > cpu
> > 0 back to its original cpu when that cpu has gone up when resuming
> > the
> > system.
> >
> > Fixes: 0763cd268789 ("xen/sched: don't disable scheduler on cpus
> > during suspend")
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > Tested-by: Marek Marczykowski-Górecki
> > <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> >
> Acked-by: Dario Faggioli <dfaggioli@xxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
