[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/notifier: simplify using notifier_[to|from]_errno()


  • To: Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Dario Faggioli <dfaggioli@xxxxxxxx>
  • Date: Fri, 4 Nov 2022 07:50:41 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ExbpruphCWrTep58Tmyi4XZsu3EPIONWCcU3hU+XZ+4=; b=b9UiEMzbNo3UM4eG3Hfej5bn+sF0Q/YNXIuKJw3OAv2X33GI1Fl4KPRHR2qUPnG+FNcc0Wb9Xx99u3RX+Vtp5w9gL1nSBUDXSpYzrMGsxL86jD97YVVhs0huy93TmvDuSixqcsQT65JVagZs2aojXz2f7ihoLCp/cRJhGkzKqBlr+DeYmmKklO57jzh9Jx0fcrsZGWm5DdH7WNEwfS0h0UAjg1ZrCyh9iKrY5/XIlmxOSa4UfGTV+eFWyUY+Mp0cYiqyK/UJTtdy4n69F7WDq+D8GQcd1MtKrfozvObldOuo5//kniCJJ4pKqd/EkjwgO8hG9BI1zOaW08lnCjkqUw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IkTKKSzCA/8XG5ZFOxL3NkfLsF5WQhLIbx79mGCZ74yXVfyCdR/AbdnR9z6WHXLaoC/XY9MUwtVfWwXrj838U/uMsGMYsB3mRTYgxAWoKHCK7zHA94ma0Q0MFwhlyKUmi1qq0sCj/Cucrm0oD2c3h03cuqcrMd28M4xDcZKueeYbUPi29REuatXtVF5B1nzhpxP8DAOoh9D9p9cuHHydMNggSkDaH4hEcyBWeyuHpObGLvtu+0N4OCMF4cFtG4r74iOxZszmiVl/Atl0DGdq1F7CDBaSHcs4ySYIzrYX67EC2EyE38YI964hR3Uti7l10kGhyuCAfs6uBAtCpZST5g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: "julien@xxxxxxx" <julien@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "bertrand.marquis@xxxxxxx" <bertrand.marquis@xxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Fri, 04 Nov 2022 07:50:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHY6sIwabOtOtASVEmIHsF4LdAC2q4ubr8A
  • Thread-topic: [PATCH] xen/notifier: simplify using notifier_[to|from]_errno()

On Fri, 2022-10-28 at 13:41 +0200, Juergen Gross wrote:
> Today all users of notifier_from_errno() and notifier_to_errno() are
> Handling the success case the same way, by using
> 
>   !rc ? NOTIFY_DONE : notifier_from_errno(rc)
> 
> or
> 
>   (notifier_rc == NOTIFY_DONE) ? 0 : notifier_to_errno(notifier_rc);
> 
> Simplify the use cases by moving the handling of the success case
> into
> the functions.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
>  ...
>  xen/common/sched/core.c             | 2 +-
>  xen/common/sched/cpupool.c          | 2 +-
>
Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>

Regards
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.