[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build
- To: Wei Chen <Wei.Chen@xxxxxxx>, Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Tue, 8 Nov 2022 02:24:18 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZICmTGVYE3R2Oh7eZQHC56GR45tyNfodhlp1AkrmuDs=; b=iTRX4CHiLDS9U7BlqVZeXVyFLEQN9J1mTO5rwCMstDV/J1vft6JhzZct91BdcQXlN3bqOiIEPcqkkqb7p1xjJf5FtB0BkPUTKLb9qsk3mSVUnSq//EErwtkFiW74FF+tDI86M2F5AGBMU7ydU24AqFs6r8F11j90QFiCs+7dZ9DDVb4tv4jnZKZEeJ1NVhTHxT0JvncCv6t3V7h7DXb78Xbqp38OriHn2K4aCFZoJm6VVG3qwGgmzbLjXls3vRmPpCOvi5wFq1euxEAk8uiSDfbrpJJH8zn0F29tMs+IR6aMxMfHKAwgHyD42zw+2imnUMuIIrchqlUshj4GrimRlg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZICmTGVYE3R2Oh7eZQHC56GR45tyNfodhlp1AkrmuDs=; b=Ams14O1KBWqcmPX5XHoTdUXm05Dd/S5YRiFhXYuKOmZURvAvGru8agk9b+PHs1uXnUacgbvrMU7hqDsBt9lT8EXOuQ78tgAuLviY+qt1FknLlXNLoSAvAuI4W/K2qsf6C4aQUWwuPWAp883i9FqGZoNCDnKoJIGbM24t2me1TOWHwbIYE9g9idTFZOUPsWDiXbBUAwEOB22i4JjJz7UfowCnUc38gb845bh0M05JvoxH9jbNZFMQQl6CSJB8g+MlYVg6K13vFkejlK1xHYbe0UGTNpGk8pXwHxnpCE1GnLMWPAS72l7r2DsaoCteF86RxB4VWSuRS1JQ6jUBpLOgzw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Klqr6KKGvOuUAavdq8HExJhL36/OX19jNhXPoanKGqDV+0BAaPME6khYNoMiNOFFIrqPxNiJ7uU4IkuFJfB1qkd5WPgtfWQAJTP8ZKDHZH716i4YCDrLxA8Ld6ORng7JCFop4M88U/dV0KPdC5fVKghk+OsgH3sG7pVlqjwcbb0Esn0tqwpN6vKkqneID6L+dmfv1/HaBwaBPM+Rrxm4RKumAlwFT2U6oitWOQ+nyPTMqG4TcYiArX5OpAVXT+5RcEDeVHRYTN5fbZkuwgsW3CaLoVyPhEEMq8PN/CaQxfwPalwbDeXJNqfz0d5h+USbn9a4nbaY34kfytW90l03cA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZUcKlkucTl71J1HIxUa7TSW0sFbMyAToGuWV5aNUJ3oTHtXpiCJyYmPIGXwxCmJKkQIF6DZ+I/knmxU4O2UmpKsceaBHY0LTNvYHf61NLdXnH8YGAz4tN+boLX2b0WqAXS6vrWOCXwPcBECIR1QD1VE8irIcpU2COxyAO53ZrOmNV1qimoxkJW73Cm4qjiHIOtcgWbdty426fXbx+42Lc7VjNrTfoBMpL1ETXwi2AS2bnvbJgikhT88NG+G63yoVwYApRbWYhlMFfwPTzL1BfZ+O4vHPfrRKvGI5/aQzchY7xU3IomCn5DRR93rdjV63AFXbdAH2rd9mv8X6+RJfXw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: nd <nd@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Tue, 08 Nov 2022 02:24:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY8DVmEdLqaRCRCUuW0jNzr25ema4yQiqAgAIMi/CAAALrkA==
- Thread-topic: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > > index 4fb5c20b13..bd30d3798c 100644
> > > --- a/xen/arch/arm/domain_build.c
> > > +++ b/xen/arch/arm/domain_build.c
> > > @@ -3418,6 +3418,8 @@ static void __init initrd_load(struct
> kernel_info
> > *kinfo)
> > > initrd, len);
> > > if ( res != 0 )
> > > panic("Unable to copy the initrd in the hwdom memory\n");
> > > +
> > > + iounmap(initrd);
> >
> > This looks good to me. But I am wondering whether using ioremap_wc() is
> > actually correct because we are reading the region. So it seems strang
> > to map it with write-combine.
> >
> > So I would consider to use ioremap_cache(). That said, this would be a
> > separate patch.
> >
>
> Ok, we will try to use ioremap_cache and test it. If everything works
> well we will introduce a separate patch in next version.
>
Or is it better to send a separate patch for this? Because I think we
might need something to address the v1 comments.
Cheers,
Wei Chen
> Cheers,
> Wei Chen
>
>
> > I think this wants to be in 4.17. This will avoid Xen to have two
> > mappings with different caching attribute (initrd is part of the RAM and
> > therefore directmap).
> >
> > Cheers,
> >
> > --
> > Julien Grall
|
