[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for 4.17] arm: fix Kconfig symbol dependency on arm features
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Thu, 10 Nov 2022 08:46:09 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zvV59+SQIO5j7s0FgVtNlBq3dHJrCCn2pQoJJWANYSI=; b=Kng1Qp142AERP+0quX4/1M/st3XWhMRRqUroLlVjPhyCn4keczwdjFvkdEmg3UvrrrQOXuyOWAgcKoJZ7V7ezyBwwo1dGA60xGjrlUu1k1E4Oh6jN78Jzt69EE0D3Ytwqv2WHEY6KlRDMKgUyzyRD6kj1H9srtYr5fpCICwmIKG8IzG+QBkCJSxVZIxum6LdHyM2s1jhM2KTjyXNsCxTIznF0r/MRQoARsQj4Uv3XumbX4EHUzGzlYvXBqu+CZQxo0P67pdxw7Y8E5J4EC9gnf5W0tRjpuHW2Q44HShB/NGooSEEcEIQTVJ2o7NP0QAdG1IzB4NgmQ1iOkDJ5AGvhg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zvV59+SQIO5j7s0FgVtNlBq3dHJrCCn2pQoJJWANYSI=; b=od1Bk/RcmlYxaHztFs+9ILqtww2fdqn+O/mAaAldcpOFFm55SJwCMyjt5z7rEENbZc0GhX8XH7yH0O3nB9/sZ8SpX8q5FtfCTQsPS3tIrOMB3B9FnsbiLOk0R3hu51C8viVqDVukkiEAJcF6bEiHep7NutDcZ4evs6sZlDSHvyr8BYZWLYLC4pSJHJem/a3eQO7bK5JsiZFxai4nrAfZDEH7uAUQsfc68AxnkXt29HGBD5XVBRFdSoFQUpgOHDsKQlbOJMJ9E/GOE/tBJS2vGik8ASp4mwSmzpA29TVuGpjtWu+DIFySWzN8ZmsthGNA177lcwCyChIuPHlsA4Btjw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nMFdNi2wM9E8aHX95weeYLYI+5Hf15lGM5CxMWrEVK/eR4YY5g0LK2zvZn3tzrbW3iz3NbuaHnCsZ6Y71j1Ri7nrQwv4I/6Fn6uukSZEUgPvr0YFtY9JKCDuI/HuL8Louju+DkMK85NHZb22oRVWwfb5BrVeXx0bIEsYKzRqHju1SMR8f/JHN7aXRZckjvbuENMqf7jGD+YdByqHEUbH+GgDgzKuau5SdTnKcibS1j7yIHBmc6Qk4kIztdeVSaZaVfUZDIm8Rue14L5tfnRc9FO7a2bSFEjt2VPnfnzxGkQ9KgJiXyH8DbfIzaOs37rKtdBlcna0UFymSVU/Fmdn7w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HfJfEnuEKR9f5cjQ/8Vp8MOtCToS/E1SVzSI59nENCO54PhO0SEoxpBUUjH79vMYkYD5kGXj8lav2iP4hZZFxM6Gm14xbZ75UNDBUih0aDVKn1sJ/x/ID5m0r3OUtyMzRyag2oo0K0hMSeXKEJqyu8x0aGT94viIVkisEIYv2cscnybyTPbDT/5P6UWn+qI+6XtQXKODuJFQZmHcV6XbF3AoSin8ux6QjsBv2WrdGsF8Vdyozay0zwI2cE9qVtHtLQ7F8iNFv2zsidXxc/O5547/MoOs8QkBmpVQyqdhXETjqfLhIBFDjW7bB1XgVsZFkn93vs81aBJjerTO52JFyw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen developer discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 10 Nov 2022 08:46:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY9EQ4iloE8yUW4kqdjRjbTbLxuq432TgA
- Thread-topic: [PATCH for 4.17] arm: fix Kconfig symbol dependency on arm features
Hi Luca,
> On 9 Nov 2022, at 14:04, Luca Fancellu <Luca.Fancellu@xxxxxxx> wrote:
>
> The commit 3c2a14ea81c7 is introducing some unsupported arm features
> that by default are disabled and are used for the cpufeature.c code.
>
> As they are disabled by default, a typo in the Kconfig symbol they
> depend on has landed in the codebase unnoticed, instead of depending
> on ARM64 which does not exist, fix the code to depend on ARM_64 that
> is the intended symbol.
>
> Fixes: 3c2a14ea81c7 ("arm: Define kconfig symbols used by arm64 cpufeatures")
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
I think this should go in 4.17 as it is fixing an invalid depends in Kconfig.
The change cannot create any issue as those config options are hidden and
default to n at the moment.
Cheers
Bertrand
> ---
> xen/arch/arm/Kconfig | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index 1fe5faf847b8..52a05f704da5 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -105,28 +105,28 @@ config HARDEN_BRANCH_PREDICTOR
>
> config ARM64_PTR_AUTH
> def_bool n
> - depends on ARM64
> + depends on ARM_64
> help
> Pointer authentication support.
> This feature is not supported in Xen.
>
> config ARM64_SVE
> def_bool n
> - depends on ARM64
> + depends on ARM_64
> help
> Scalar Vector Extension support.
> This feature is not supported in Xen.
>
> config ARM64_MTE
> def_bool n
> - depends on ARM64
> + depends on ARM_64
> help
> Memory Tagging Extension support.
> This feature is not supported in Xen.
>
> config ARM64_BTI
> def_bool n
> - depends on ARM64
> + depends on ARM_64
> help
> Branch Target Identification support.
> This feature is not supported in Xen.
> --
> 2.17.1
>
|
