[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs
- To: Henry Wang <Henry.Wang@xxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Thu, 10 Nov 2022 08:41:01 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TXednF7H5KKFrI6WoKZEcOzsDTsiotrORWgCBbkEkpA=; b=KYrDqhbfcmV83egFnZfZEtZINR+Qd3TT4UiE/6bPb1+UQDoBhQLfH+zOkbLNjg+cAlCr3wlvHDG6VmXKy4a3Euj94JosRr/EtVwwr0jLRSVxEN4wYIToKeEnJ1DbhSD2EgPkMCMJZWJou83mXD7h5cE5emcZ/+AVdKsQsGJE/MGoV+So+hdobSOz5Pt1tqhKzToORwjt2eGU4dPSjWfK8Z+AgrGVN1LHKnN2C/0zkGL9vWxtRyq+tpvwJfxI4aiirdq5esQUfsyF9USdFfqX14Gp0Eq4EN2Bj9iiWqL91LVKBKGjuaLUmwUNJjv5T7wlNMr2IMV79URfsibss0gIwQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ksLfTf9WY/n6jycoMKvWcFgF36SbKLynvJ6k3qvmxAJr7ZQkROnxZzNoXoREZwvaowUoEDuAXP0iJ4jxWaFwl54oRISZgL0gWvJqU2nW7LOt/PJdmFIZ8Wo2Ya45ZqWIDaYiKPN+vn2ttQiQQ8j08MsJpohXfCrgpbjBYHGvDX+0EVZtm5e+V93aHQHjgAxhaDf9BWSb+ANj/UjOL9/bjiBmlAQkxTRhRKGyw/NJU7TkmCfQyt3jWU4WExV2CpH/qp9PMOTM5G9C+PLYnx3oJ6xmqlDxh/AhqmZPPk74Nx0uCfohkKh+kBfsOKZJPohjQf4kOTBs8z+/jFEdUJwrHQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Julien Grall <julien@xxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Thu, 10 Nov 2022 08:41:52 +0000
- Ironport-data: A9a23:MwCAw67pvyxWjY/jYp2gBQxRtPfGchMFZxGqfqrLsTDasY5as4F+v mNOD2iAM/feYGX3KN1/bozk8EJV75DdyNcwHgtp+SgwHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkS5AeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m7 fMgKioiT06/g924zfGhb7R2je07I5y+VG8fkikIITDxK98DGcyGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Ml0otidABM/KMEjCObc5VhEeDu mPP+SL9AxcWNdO3wjuZ6HO8wOTImEsXXapCSOTjp6Ax0DV/wEQOBhk1FnKdmsPloXObd+9kM GlN3zIx+P1aGEuDC4OVsweDiF6JuAQNHeVZFeIS4RuIjKHT5m6xBHUATzNHQMwrsokxXzNC/ k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMt79D9rakpgxnIT9IlF7S65vXqHRngz jbMqzIx74j/luYO3qS/uFzC3TSlo8CVShZvvlmOGGW48gl+eYipIZSy7kTW5upBK4DfSUSdu H8DmI6V6+Vm4YyxqRFhid4lRNmBj8tp+hWA6bKzN/HNLwiQxkM=
- Ironport-hdrordr: A9a23:OhIzOKCxCKI2UPblHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkWwqc5Ew6sN5m1q VXm2qfqppMFBvF2D/w/t7SSnhR5wOJSepLq59ts5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7gSwlGl/NLAgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vcPHmZw ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY84fBVQkM1eqLakCv8k675veNsq41MEgAgACx3ICAAfcdAA==
- Thread-topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs
> On 9 Nov 2022, at 02:40, Henry Wang <Henry.Wang@xxxxxxx> wrote:
>
>>
>> -----Original Message-----
>> From: Julien Grall <julien@xxxxxxx>
>> Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add
>> 'make format' and remove tabs
>> While I understand the goal and support, this seems to be a bit too late
>> to do it in Xen 4.17 (we are only a couple of weeks away). At this stage
>> of the release we should only do bug fix.
>>
>> This is clearly only a comesmetic change and there I would argue this
>> should be deferred to 4.18. That said the last call is from the RM.
>
> I agree with your point. I think maybe defer the patch to 4.18 is better,
> given the deep freeze state we are currently in.
I disagree. This is an automated change that can be verified to not add
functional changes. Edvin has demonstrated that wrong indentation has mislead
reviewers in the past and caused bugs. Nobody except Edvin has contributed to
the affected code in years and thus it is not a burden on the project outside
the OCaml part. I suggest to accept this.
— C
|
