[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs
- To: Christian Lindig <christian.lindig@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 10 Nov 2022 09:25:36 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I8lggpRIGZfOiJs0bWT/CM5KKEs5qWogZqPrPKzVnZs=; b=DddwQGR2Gj/ttf7Q6kZ7L2BkjJWoEvDzo5LAlQBORKfYuk19RAXweglzlcfrD3DIwMkKBuXctPymssWLBio02k5uIGYC1frUYG5AAAf5hs5G9zfHEqhcGkBMzKXyJvV5nl+vdco7PI3U+l71zZDLGBXSfUdqX4g6GGDCdzJQ6CIm5VeTDKDNfIeXFxdU6Cy8xSyIrPIKJKHMW2eCG08LS6EZq9xTTTy1ndtXfsiCbRj/IwSLLHPDTSWwwoo6May/fby3X4OpPJtnqIM+mjTmOAgTg54D0Ym3N1pa1YKv9yAfCePYmTwsp2Hep6qhuCg5pGYw5Ip50Zo8U7Una+x/rA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I8lggpRIGZfOiJs0bWT/CM5KKEs5qWogZqPrPKzVnZs=; b=cx8RV1rh/bTItAPCWiJL+h8GAttfHlSOyPdoe97Y/JmKScCzg/ewsVV2C9R8ThojGXkh0DXA7dmCZsi0OA0eAeYOBb4yni35qKHJPpSLbnjHIe0iYGtZQK8dMgnm09vrd1VzRaK+N2RCyrBd6vADeo6htdmLz6kSmrjQP8kQV/zpu3gTQzanvCrVp0bD7Iinc5JOVYJyuhXJQNOOpyDd3bZbvVDNTqBn5FlXBljLIeREvC6EmvhZacleSWXU/dlAlCwuZ6X9fuRACFGl/9Ip+jLAFtnU62QyryW04j0RuAfaQuFH30mX7qJMXFfyTroM6T91YJ76OVPDiRVEF1cN4A==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=b2EHiCWL4CYy30M+lFqrwwWVNzUB00b96X8DO42hlJEO3J3xc/6T20uj40RED/UVlifIFrtWZWYuY/wtVPFe1T889b1RQdmMn91eamJWiuwOc7bQ6kUcbKqPzqoN1/IB7mEwRXztxYl2Y/3xe0fbVkZ6ChBVfzHEYoltzUT2QYmpMDv1zkKOjKGJP0TZczNpdnsQjziQo8QBZ+7/cqCc2Ktjrvh0RJ6VuRaS6sH9hj+FyOymRDHiuM8stcayPJ9zzOPN9crifdxz/K+EHwp3ltLu892OfdZtTJjifzGSzX7g3cnvm6pqqDH6wfgOTgp9ZlVeIzgt8Zf+jSGqIamhIQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OUMaDpNZda7R+nWJzLzXs45L1oxy4Ek3MrKhyiNfVSy/ggBkfobF6ZLKYK6IEYc8Yvp8GwJxEIXh1L3EpQ7D8ezf9nO4rtNvb6eTRnMSBeHFT6d7TWcfQUzt1wLhL0gayZ+htbvhlxn0PkTyINawYuq3zuFKZb/HGRnVl4HJU43tFY7tJ8gRgMVIaTbDD+ymgpHhk+dqwlCFZgXRVdMcGBK5VdYZaTI9kzCCep2+Rs5ibf3PiE2mstp68jXiUNCXie/GpbbyOp6p34dNVV7MHcU5q6KyFTB7+xmSGrYnsZuTtIKhnBdUNTvtdBt4j3pJz3TZTIva3whXaCnDYEUK/Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Edwin Torok <edvin.torok@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Thu, 10 Nov 2022 09:25:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY84e5FV9zwZ/cMEqESsIC5Hbn0K41MEgAgACxXpCAAfedgIAACnbg
- Thread-topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs
Hi Christian,
> -----Original Message-----
> From: Christian Lindig <christian.lindig@xxxxxxxxxx>
> Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add
> 'make format' and remove tabs
> >> While I understand the goal and support, this seems to be a bit too late
> >> to do it in Xen 4.17 (we are only a couple of weeks away). At this stage
> >> of the release we should only do bug fix.
> >>
> >> This is clearly only a comesmetic change and there I would argue this
> >> should be deferred to 4.18. That said the last call is from the RM.
> >
> > I agree with your point. I think maybe defer the patch to 4.18 is better,
> > given the deep freeze state we are currently in.
>
> I disagree. This is an automated change that can be verified to not add
> functional changes. Edvin has demonstrated that wrong indentation has
> mislead reviewers in the past and caused bugs. Nobody except Edvin has
> contributed to the affected code in years and thus it is not a burden on the
> project outside the OCaml part. I suggest to accept this.
I understand points from you, Edwin and Julien, but I think in the earlier
discussion in this thread, Julien has provided an argument [1] which I do
think is a valid reason to defer this patch a little bit.
But since you are the only maintainer of the Ocaml code, so if you strongly
insist this patch should be included for the release and there would not be
any more explicit objections from others in the next couple of days, I think I
will provide my release-ack for the purpose of respecting opinions from the
maintainer. Hope this solution should be acceptable to you.
[1]
https://lore.kernel.org/xen-devel/1f8c90cd-8037-84eb-d6f7-c639f8a87585@xxxxxxx/
Kind regards,
Henry
>
> — C
>
>
>
|
