[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs
- To: Julien Grall <julien@xxxxxxx>, Edwin Török <edvin.torok@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 9 Nov 2022 02:40:17 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rJI9kTwRBOa/c1sY7fIKdF6hTs3hnFzn34HhwC6tq5Y=; b=mDtBzsEKOPoQP0v9uMEBqjzjoTrPnCGot7xNza639gRv9PGBSAPWMuD3r5el+iZR0tW/24XZrAPwoWT1+GroQ9YHgWOzyidTnB3cEA+RlIBfzqCzy5Wr1c+KdLfRzknAK+FyJsMcUBDosavLpwPoUz7uEIk2WIC0Gjx4wk6ANk8kJ1WyFZChgDxtSeY3QbUG0Zb9h4IyJ3LFJ+sDp6gdUzGMPWVsKObw+NqUqZrxmJ+H3E/evC8aY7fAmsAgeWv+6yMsmv3TdbEjr07QXSBlK0z3EV7puTX6dIxE2VuBO6QYdLMV0xuZQJblYWuK4DTwtl58CLf9RpplCaU5aLhCDQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rJI9kTwRBOa/c1sY7fIKdF6hTs3hnFzn34HhwC6tq5Y=; b=Me5gMhsLBdN6Dz9oI4jU9noY8VhiHAPW5hSTNxITZFBq0nhtO0irBhsnWK1SQkX0o++Z17Hpipp6hVh+S9r1qYyQvExg2zQKCX+S9JPjhdAjdfX7ZZ/U12tc/OnHdjIqg/Yh0yFaBbdfusY7JIE0bKQvuKdLlgDMzpxU7ur55XPJN9sjcZXSFOOZ0hdM5u4/znZ//4/s+bPFlXDn4Wch+GKhzl7Dirn0QwhYcOSD3FvCkKmwDRzAjMVWP++dDj7lW11K4SpjCkQhXfuqb7NFHHwA9ZT2q+EWvwBaW+q3J24l/TrgkAwGDq/ppv8K858gVuf/4QpfGqBGQ/3jaLEp7g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CKD31KUqimQmyA0Nt2ggGzAFw8oGtnhJXhkjhQlW33IaBRc49yh88Et6hKDu9nNESV4DHZChSE0jqL8Drf9I1RPES5mvKFE+URmSuYLmRArNLECK28qlcwVp/HzVJzOhpBWxWNRjlwSxp7ShOXwTfG2eDIYmN8Jl/NkGn7IDtlvJKXmIJu8wC6sm+WUuwdFPrtPhUdByRWCgJihDFnPBCkRxPZH+IJ6zhtItKYAkX3fy6RX8unbiuxESWNf+FIylagR/oz3LG8nKwcjH8IkofoOWsAurMr2LfUFq23DyKrHm47ANyT/+Cz4uFd5/euBb974lLd811ntIJXaKj8Q1pg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NJ4n6I370mGS7LjR7McsApYWYI3mMcPdnYqTnIZXR8jCgTSOuqGYNmIbB0WNcH3ozVXQdBuWjr50xtX7BXMYCYyMXpKRwWwmkqCb7fawCJMrID0wqnPyQv0R5krHXyFhziN/tWRk9QKoMx6c5m981pXdXxMz5os4rS7Bv1gptyrN0QLP1zcH5OG3kVFcOHu/1vf6FXt0gsEtjzelDGJD9aOicP2OWC/4W/QhrN1C5lczu1xraeOGLwZL9tAxvQBlCyOqPOOZ8wHEEGE+L8+nIjFmBprXo8rzzHTQJ8uPensi5SD9RJUf9NMg9WTsxLuP2sJavPSeQsAlfsmzSwAe3Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Wed, 09 Nov 2022 02:40:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY84e5FV9zwZ/cMEqESsIC5Hbn0K41MEgAgACxXpA=
- Thread-topic: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add
> 'make format' and remove tabs
> While I understand the goal and support, this seems to be a bit too late
> to do it in Xen 4.17 (we are only a couple of weeks away). At this stage
> of the release we should only do bug fix.
>
> This is clearly only a comesmetic change and there I would argue this
> should be deferred to 4.18. That said the last call is from the RM.
I agree with your point. I think maybe defer the patch to 4.18 is better,
given the deep freeze state we are currently in.
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
