[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error
- To: Edwin Török <edvin.torok@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 9 Nov 2022 02:47:54 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9qlAgcfp8B8U8Fub1fPIWg/kuXk9QLyoBXzikwze/P0=; b=bXFrS2dEH9AP/0jd++2y4bM8Mvwtc6ua8yv50y2PmCML9ls5AUoKLEspY//dNWDxIvql35eCsck6LFdqUedtOHU59arHJUizMJ11pwMlstSm502Q+V710+rNB6URcaZwfsZ5fS1FOjW6nBhmoxBCIzJUdbV579NnOEvSKr+o9Qh1h5qsz1e8UfzVosU8zPHxypu+LuROgF4zeQ3o5YKu3w078EnC3qzC1EtmK2G82VaBj0BZrBhY1BrYVv8ijw3jcDbqwg30DEDZFtp4JIVL33e2CvqVhTFjA92JN1n6C/UJPzW/ZpTiqqvVrktVi55zjnsAH2hqPjzy3QBjgTOtSw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9qlAgcfp8B8U8Fub1fPIWg/kuXk9QLyoBXzikwze/P0=; b=KCKOHxFyPOSeldSM9QIIaV759GtYYhpDb85jG2VTTqDPUhrNT0SE6i+ZK02uafH2q5qzDfGv83RtLkVLd+aA15zbnxRCXr/t7AIwcmK/H4hsPZM4/QUI/l4Bm+P/VzjfPSsolqIIjfw0iumNgPT5h8X38W8VT/YvTn6H0FiRg45CIoD1qlkg9nYKDjN0eV+9O2f3C7ITB0QBD20xtN3TH+g3zcfPtB9vBMpr+ZtylEdQ8kfYi2ZI+SPEN6fgmuKbGsbrW7NDjRk0/vJw2GhobkI0oL5+r75JODTvFu+gdB2RZyRdlkum65nxTi9PXEBjfoawWU20Z2BTYyV5rsIgGA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LETvaTxB1qkAI2QcEB7RhW41jNKP0pTp7h0jMSqzfX/RUHn3PpLMl8NQXuPIzZye7TBwXHV0JAMm6ahfti+ClfylbuGT5+iBnOJBKVyE6igK3Ed5khGJUKi/nWejD5I2v21Q65k+Vudg51DyaGcMMuenXZKykic05qr/PI9yHnAWQLOOFbMHAfB7Vw0okO/TdIc3iScFZA2v3+Fh2PIwoUNivaPv5U2sg1Zs41LeRljmLoJlI3pcsKGVNkvlTX2dPsG9TR8anVI0lbU61U2HBph7MJnElmtho5Xy/7iTg1/t+mmgSNfLGyfJpoPeWaL7CZ9lc73+sTuThnKYWCexug==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oFdHTDwqnEy0aI0O033SajQBIV3X2+YlsDOIEuuTuHbMnLcP5v35ducZMHj0mQIzvoxqJD0jJMc6aZkeA9jtEhSMSe1f+dBKj7zLMoRAMFQHWk5ZyRVa4KXriJeWG4h+yDk7GQ5bjd4gVgczlMQwE16Gc0vIkk1hVikU5IPSrKVIZh3W1ZD0K2TKjGaq1FsBqF1VSsNZgIa8h3kVCqNoPiDx/BwvRINOEytVlX2NKWuZ/fGexplh+gGNDIdfZb7tWBOhjK4vPpuUP3BLACUIVXl5E29Y/iPqisvZTliJIDa54ZPFIEjYP+DwB99F56grWeHlJOcU4jTbsTmEez7nGQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Wed, 09 Nov 2022 02:48:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY84eqgKyNiLgv0UCPJRPewn86Na414+ag
- Thread-topic: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build error
Hi Edwin,
> -----Original Message-----
> From: Edwin Török <edvin.torok@xxxxxxxxxx>
> Subject: [PATCH for-4.17 v3 09/15] tools/ocaml/xenstored/store.ml: fix build
> error
>
> Building with Dune in release mode fails with:
> ```
> File "ocaml/xenstored/store.ml", line 464, characters 13-32:
> Warning 18: this type-based record disambiguation is not principal.
> File "ocaml/xenstored/store.ml", line 1:
> Error: Some fatal warnings were triggered (1 occurrences)
> ```
>
> This is a warning to help keep the code futureproof, quoting from its
> documentation:
> > Check information path during type-checking, to make sure that all types
> are
> > derived in a principal way. When using labelled arguments and/or
> polymorphic
> > methods, this flag is required to ensure future versions of the compiler
> > will
> > be able to infer types correctly, even if internal algorithms change. All
> > programs accepted in -principal mode are also accepted in the default
> mode with
> > equivalent types, but different binary signatures, and this may slow down
> type
> > checking; yet it is a good idea to use it once before publishing source
> > code.
>
> Fixes: db471408edd46 "tools/ocaml/xenstored: Fix quota bypass on domain
> shutdown"
Nit: The format of this "Fixes:" tag might need to be fixed?
>
> Signed-off-by: Edwin Török <edvin.torok@xxxxxxxxxx>
> ---
> Reason for inclusion in 4.17:
> - fixes a build error in a previous commit that is already in master
Yes, given this is a simple enough patch:
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
