[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17 v4 0/2] amd/virt_ssbd: refactoring and fixes
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 16 Nov 2022 00:27:29 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bDY1n0zx5XrQfBGzlxZ1xOw4SH5C4MpYOVQornj6lmM=; b=UjduwSwfdfu4pAkvtAzH05EQTnJodKwnEtJp/9p3Q/33eJCoZz3NQoSIVpPuaoZG8NPCXzeOHK3DSMqIcZr1y0Kc6ryxYDh1OfetdsyjeayYaDRiUJYBwKAndsq7WTBK/m9FJ11Xry3uJIWKbSuA0TTpsncqO1/XHGjOntsMhx3e7ZyDxQ9XavJqfRcYxN2w+E+9R7dzCFAcAuBoXhG15hqEUiOm5lNLNK1TUE9P4wJ+hAypEo5FPAXIbkk4Og85JG8tZasRir6GQyvgIeoQEVFK9o2h2pgxNrrvXobftNn+/50IY768OErEwzwKZLHZ0he8KfbtzVkLincsbDg6iQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D3uluyybXsxoqMah8vfWsgxJNe6kmO78nbaNxpmnu2tHcmnLl5CBTxe5+TzZcntkyng5r1OHLvS6lgkW/Ot2mbqJ88NzrmEOBezWtTxCOmGp/mweyaMJ4mLkNLyk3P4uaFzKrbmDsZ/SWWELN5/w7mV7i3n+kXEMVVnevleVI1kDDMEvykGkci9uEGmytmJEYgnAHrmOhI4TyM4+warvHfFP0xum35vEJU3pWPIdWMsYhhJF2e8aklnT0kaSA9fFzsszhkdwDLXtqkNqEfcszNNkRosdhPLEu/kTHagBkvT/8QwLE3GsWhmTJNlysjIVCCGkzvEvgHd/tXLe+Qmx3w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "Henry.Wang@xxxxxxx" <Henry.Wang@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 16 Nov 2022 00:27:58 +0000
- Ironport-data: A9a23:HZYwA66qJJqrU111g7uXSgxRtN7GchMFZxGqfqrLsTDasY5as4F+v jBMDWmGb6uMamf1e4x+Povg90ID7JfUmt9mQAE5/itnHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkS4QeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m8 qdAJD0fVB66l9m03+q9F7Ro2dhkFZy+VG8fkikIITDxK98DGMmGaIKToNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Okkooj+CF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJNSOHgqKE06LGV7kdIAkUSZXCbnfuWlEi1cZVRe nEQ3wN7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OcWSDowx xm2ltXmLTV1tfueTnf13rWeoC62OCMVBXQffiJCRgwAi/HhvYUygxTnXttlVqmvgbXdAirsy jqHqCw/gbQ7jsMR0ai/u1fdjFqEuZzhXgMzoALNUQqYAhhRYYekY8mj7gHd5PMZdYKBFADe5 D4DhtSU6/0IAdeVjiuRTe4RHbavofGYLDnbhl0pFJ4kn9iwx0OekUlryGkWDC9U3gwsI1cFv Ge7Vdtt2aJu
- Ironport-hdrordr: A9a23:Q/A3XqvsRVrEU9YUD0hisTao7skCXoAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeF+aP3CB+R2zYZSndqza05+W bIvgTl7uH72svLiyP05iv21dB7idHhwtxMCIiljdUUECzljkKFdZlsQLqLuREyuaWK5EwxmN fBjh88N4BY6m/XfEuyvRzxsjOQngoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L gj5RPbi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZDIMu60vFjLA BdNrCa2B9kSyLdU5kfhBg3/DWYZAV2Iv5BeDlbhiXa6UkMoJkz9Tpk+CVWpAZ9yHt6cegF2w 2MCNUXqFkFJPVmEp5VFaMPR9C6BXfKRg+JOGWOIU7/HKVCIH7VrYXriY9Frd1CVaZ4u6faoq 6xJm9wpCo3YQbjGMeO1JpE/lTER3i8Ry3kzoVb64JisrPxSbL3OWnbIWpe2PeIsrEaGInWSv yzMJVZD7vqKnbvA59A20n7V4NJIXcTXcUJspIwWk6IoMjMNor239arOMr7Nf7oC3IpS2n/Cn wMUHz6I9hB9FmiXjvijB3YSxrWCzjCFFJLYd3nFsQoufsw39d3w3koYHyCl7G2ACwHtLAqd0 1jJ76imr+npACNjBT101k=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY+PYA4G97GRMYN0qVEBZj+Syg765Asn+A
- Thread-topic: [PATCH for-4.17 v4 0/2] amd/virt_ssbd: refactoring and fixes
On 15/11/2022 13:26, Roger Pau Monne wrote:
> Hello,
>
> Just two patches remaining, and the last one is already Acked.
>
> First patch deals with moving the switching of SSBD from guest
> vm{entry,exit} to vCPU context switch, and lets Xen run with the guest
> SSBD selection under some circumstances by default.
>
> Andrew has expressed reservations to me privately with patch 2/2, but
> I'm still sending it so that comments can be made publicly (or the patch
> applied).
>
> Thanks, Roger.
To avoid a further round trip, I've committed these patches with some
minor non-functional adjustments. In patch 1, an expanded context
switching comment, and in patch 2, an adjusted commit message and
movement into __initdata.
I've also closed out #90, which closes one of the release blockers.
All other bugs can wait until 4.18, including the totally bizarre one
where using cpuid="host:virt-ssbd=1" in the xl.cfg file causes IBRS to
become hidden. I confirmed this was pre-existing behaviour, but haven't
investigated further.
~Andrew
|
