[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17 v4 0/2] amd/virt_ssbd: refactoring and fixes
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 16 Nov 2022 10:53:44 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p7xp8/z9qJ1911Wz8xxNNdV/aliKN4iBFIKwbEU197w=; b=J/Du+snAwg2SQpGTbc/B16Pb5aZdsL68kpPIy9qxRwYm/R54qhUpQ3Qu6Pm8U0g7A8bv4WyCPQSKBTy1S2PmF25GEONgMpP17YLOtccwV/jHjRELJcPfENKNEezT2dVEiJfeltqnropnoOG+ApU8adfMa5cBy9vb9Jae8UDba3JM0LNNEviUZ+X0WBNnRDddMqXPzlAN/7wUp7Bdj5QTaNOiZUiKQFnCkRJBq0finr33Q+hJg+1NYTELd4lVnO17QaVjrK4g5Xd0H3ZfcFFk4tZdjZ3DzWL/vH2jFBFu9l/3a9fHe7Y3ucG+9MUfaLn3wLtkWUXgJQo1f4WikNWYtQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ReoFBBtCN2r44imbOccYO9cSQIBY8HAZSCtfuUNiEr/XoI+Zzxd7M6xr87NPDioeJOsXWx1ECaJAIx4GuUlBm6vFNfDEdvoQ33ipIFebFq58+bSoyKt+xN9HhVNdZYsBAgIEEHCQxJLsLTJxqiGBlGXRtbmm7TyvTBVxF9fKtoasZHxoXXLqWrsMuIwedVHJ3v8sK7C9+jtfbaPVI9uOnVci7IBsCH7auPAQ2oTUUgNhKJgpe6wRSFW2qRWedVPyqAaIp2QQYoWqFmMIJxAiFZrD+cuGbUgmpbgkllmLuPpKqXr/8q/58N+Ai+2oSe5SpJpV11hrjnDEHC3zvPQVQw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Henry.Wang@xxxxxxx" <Henry.Wang@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 16 Nov 2022 09:54:16 +0000
- Ironport-data: A9a23:rKFgu6y9H0n1MMxD5356t+fsxyrEfRIJ4+MujC+fZmUNrF6WrkUBx zRLWD+PPquCMTOme9EkbYW0pE4BsZbRzIJhSwVl/iAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVnPK4T5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KU0V+ c4HBXMsVwG8tsSZ75eZF8hQu8t2eaEHPKtH0p1h5RfwKK98BLrlE+DN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjWVlVMtuFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE1rOewX2lA9x6+LuQ8dItkXOr1DcpEUdIDXyBu6SbmBCjVIcKQ 6AT0m90xUQoz2S7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZh5MbsY38vA/QzMC3 0WM2djuAFRHsreYVHac/be8ti6pNG4eKmpqTS0ZSQoI5fHzrYd1iQjAJv54C7K8hNDxHTD2w hiJoTI4irFVitQEv42k+XjXjjTqoYLGJjPZ/S3SV2Ohqwl/NIisYtXy7UCBtKkcaoGEUlOGo X4I3dCE6/wDBo2MkyrLR/gRGLau5LCONzi0bUNTIqTNPg+FoxaLFb28KhkkTKu1Gq7ooQPUX XI=
- Ironport-hdrordr: A9a23:RDkJF6k8f1yvpIkErReT1oaXVdTpDfI33DAbv31ZSRFFG/FwWf rPoB1773LJYVMqMk3I9urwWpVoLUmzyXcX2+Us1MmZLWrbUQKTRekI0WKI+VLd8kPFl9Jg6Q ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Nov 16, 2022 at 12:27:29AM +0000, Andrew Cooper wrote:
> On 15/11/2022 13:26, Roger Pau Monne wrote:
> > Hello,
> >
> > Just two patches remaining, and the last one is already Acked.
> >
> > First patch deals with moving the switching of SSBD from guest
> > vm{entry,exit} to vCPU context switch, and lets Xen run with the guest
> > SSBD selection under some circumstances by default.
> >
> > Andrew has expressed reservations to me privately with patch 2/2, but
> > I'm still sending it so that comments can be made publicly (or the patch
> > applied).
> >
> > Thanks, Roger.
>
> To avoid a further round trip, I've committed these patches with some
> minor non-functional adjustments. In patch 1, an expanded context
> switching comment, and in patch 2, an adjusted commit message and
> movement into __initdata.
FWIW, I didn't expand the comment in patch 1 because I though it was
likely to get out of sync.
> I've also closed out #90, which closes one of the release blockers.
>
> All other bugs can wait until 4.18, including the totally bizarre one
> where using cpuid="host:virt-ssbd=1" in the xl.cfg file causes IBRS to
> become hidden. I confirmed this was pre-existing behaviour, but haven't
> investigated further.
Hm, I don't seem to be able to use cpuid="host:virt-ssbd=1", I get:
# xl create -c tests/virt-spec/test-hvm32-virt-spec.cfg
Parsing config from tests/virt-spec/test-hvm32-virt-spec.cfg
while parsing CPUID string: "host:virt-ssbd=1":
error: first word must be "host"
However using
cpuid=["0x80000008:ebx=xxxxxx1xxxxxxxxxxxxxxxxxxxxxxxxx"] does work
and I can see both virt-ssbd and ibrs present in the guest CPUID on an
EPYC 7543P (Milan).
Regards, Roger.
|
