[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 16 Nov 2022 16:56:41 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JdrdXiH1ABEZhHd7nlJNLMPNFakmbMyUruAfXnFfDlY=; b=N1h8em5vAIZTSFSShKwWg0uxPYdP14ADiZsYUqT1yJHLUWKZWfBq49yGljQUL9X8en75Hga3scDv4v7PFHJdogxRuW4wxAG6Zb5iFJaTf//n0hGSIh6dtFykXjRSmTcV7NT9FL9CTBEAlyEB5DTcOhAHlx94TpfLBj4fQNiRxg4cqYVs3UzurgAn5dkUvUfkQ878ff06+FGIXL777HdjJdcfTQR4gdlaWdqc0uisCz5DUYgsgYN9miKp0s3zcKzziXK0xss7Lzm+1DZJY7C4EABu+C5gpHNxoAf+27PYD/4WJJLyn6mZYa94Dik6bj7mMS+Ng+7r4STVo9Rn5Db9Yg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CKpx6zG9f1FsLEbjTDhc5FmxSCec03qMek85z1vcqvhoiwdS2pzVrlIEWEAHrYrwZDeSo8KP/qp5l2sb3QFXY+qWBjFhj1Nb7jSdIHtLMWrc+39W7QnVCQjT6ZIQv1O3mjc7fxtqcvZokjMVchBIzXm68topbAd8nsDkTG/rU9eMNjp3Vcq1ZDabqntccRrayolV6havVOe/c+v2UHlol3JWe+3YMyKwdAaUShRF2ynaBX94lchr0blcM3fFp12e+8tBGFaf8UsD0OvGC7M+4718f0WHX5tuLwb37HVNyDekW2e6mCJshXF5ILmF6I1hnmV080EyLZoRan8RtTiTng==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 16 Nov 2022 16:57:00 +0000
- Ironport-data: A9a23:JMwIZKsT9sPOcuE0Q0WOVA6G8ufnVHRfMUV32f8akzHdYApBsoF/q tZmKWqPb/fZYWb2KdsgYNy28kJU656An9FkS1M5+H08F3wU+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QaHySFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwKHMSNE6onPKK6YmmEfNGv54yNJPOFdZK0p1g5Wmx4fcOZ7nmGv2PwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjf60aIq9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPO3lra4x0AHCroAVIAwbd0XrpdSEtnKVR4gcK X4PpnoynadnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQo3 FKUm9LiBRR0raaYD3ma89+8sjeaKSUTa2gYakc5oRAt5tDipMQ2kUjJR9M6SKqt1IStSXf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxodu51knHpU KA4pvWj
- Ironport-hdrordr: A9a23:RilM8ay2DX/4/v/sGw84KrPxBOgkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2jnC6l87nzFjmfx1M7XylUybkv3G DZm0ihj5/T8s2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHBmxulf4NoXpyFpXQQrPu04Fgnvd HQq1MLPth16VnWYmapyCGdlTXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t MJ40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIWLH5AJlO+1GkUKp goMCju3ocRTbpcVQGBgoBb+q3pYp30JGbffqFNgL3P79EcpgEF86JR/r1iop5HzuN8d3AM3Z W7Dkwj/os+MfM+fOZzAvwMTtCwDXGISRXQMHiKKVCiD60fPWnRwqSHqYndydvaD6Dg9qFC7q jpQRddryo/akjuAcqB0NlC9Q3MWny0WXDoxttF75Z0t7XgTP6zWBfzA2wGgo+lubESE8fbU/ G8NNZfBOLiN3LnHcJM0xflU5dfJHECWIkeu8o9WViJvsXXQ7ea/tDzYbLWPv7gADwkUmTwDj 8KWyXyPtxJ6gSxVnrxkHHqKgfQk4zEjOdN+YThjpsuIdI2R/xxWyAu+CSEz9DOLyFeuaore0 Y7KK/7k8qA1BuLwVo=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY+dppI/YDqtuG9Eua4T+BrggU9K5BxRYA
- Thread-topic: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0
On 16/11/2022 16:42, Roger Pau Monne wrote:
> Currently Xen will passthrough any Local APIC NMI Structure found in
> the native ACPI MADT table to a PVH dom0. This is wrong because PVH
> doesn't have access to the physical local APIC, and instead gets an
> emulated local APIC by Xen, that doesn't have the LINT0 or LINT1
> pins wired to anything. Furthermore the ACPI Processor UIDs used in
> the APIC NMI Structures are likely to not match the ones generated by
> Xen for the Local x2APIC Structures, creating confusion to dom0.
>
> Fix this by removing the logic to passthrough the Local APIC NMI
> Structure for PVH dom0.
>
> Fixes: 1d74282c45 ('x86: setup PVHv2 Dom0 ACPI tables')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Yeah, that was never going to work correctly.
That said, I'm not certain we can get away with discarding them either.
Some systems really do use ExtINT in IO-APIC entries, and dom0 is
capable of configuring this if it thinks it wants virtual wire mode.
Is dom0 likely to get more or less confused with the LAPIC not
defaulting to regular x86 norms? (The answer to this question is
whether we should fake up up an NMI structure for each vCPU.)
~Andrew
|
