[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0
- To: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 17 Nov 2022 11:35:13 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZSaoL3foRwDHJ84aHiU2WU2nhqVi4vluKK2+KvEBuUo=; b=HVDJbscpWISEtRs+kg70XDV3zBcxdB+Qu6dgfDFgGakuVq3A7R6zdMF4xx96a3LNAUTKTf0ynbzeVOvLI1oMPZ6IHqY2GWgxwYFdNImIuljlJKcK0zN7blCQrNYimJ/z+7qMUxi/zMBqfSpmeTMlpntjw7gCDO4zz+8Pj7ycm7iUlXU154il4IWpthoHabfnpMxZ9+O40AvMEC0+YNVrtDj0OVw5DArmNuXP64kAlnnYSDSatpyrfk4Bd9DvCJl4XW6UbhU3cmQe1QipdIOND96eC2D2Bmgl44oNe93Yev9qzRzWJ9P7pnI+g3wTpqYSlNLT9xzJnV/GNm6U5nop/A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ezp230hIbmlqW5vT6ku98JfkKEXeenfSmcTQH+VGFi0qBcrI71MqQmaIZ3rik/KH/VLNaX4F3Ie8EPOxNSlqx1E9pJjmzcfvWWXgY7G2Wu+EI2sohjHY+O/2GUHr4MIg6uNwOOUAMvfYNI3dGwA7efZU5G3R3q/oKKEID1DlODz8fheA0Lffqrz+QQO8O/7rHh+3bbwb2Vcr3EVM7rRo3Gk37xg+XMPSXxboSDyCxotve9eeVmhc52BAO0yDYxg5Z6m1hw2Np8mSgCA43HdRLZ33M7MgQ0SPYoxOPdFTLItvOFbMZ0K5HKK3ivm2zNpLUfukBJGeveudfJFm8hmUWw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 17 Nov 2022 11:35:34 +0000
- Ironport-data: A9a23:+Hkk+6ry4GaVDU2wucsjAgNUwxdeBmI6ZBIvgKrLsJaIsI4StFCzt garIBmHa6qMNGf0etwnaYu1/B5SvsPVn4RlHQY6rC42HnhG+ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06W1wUmAWP6gR5gaHziZNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAA0GPxHYuM6/+4ucSNV1h/8HJZfPEIxK7xmMzRmBZRonabbqZvyToPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeeraYWKEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXoqqAy2wPOngT/DjUnc0rrseTginKlfMwYB RQ3vTUCtpELoRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LRQ62 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBscOcey9zqoYV2gheRSN9mSfexloesRm62x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBNzxooWp1 JTcp/Wj0Q==
- Ironport-hdrordr: A9a23:o1KPBKnpSVWxlcQg0Sn3uWDmwanpDfMEiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJLqDhSC2R8acjVXhZMv63 LMnQDV7riq96jT8G6c60bjq7Bt3PfxwNpKA8KBzuATNzXXkw6tIKhxRrGYuzgxgee3rHInis PFrRsMN9l6r1nRYma2ix3w3BSI6kdh11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza NixQuixtlqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bWDHAcEcYa xT5fPnlbFrmGChHjbkV65UsYWRt0EIb1O7q445y5SoOnZt7StEJgAjtbEidz87he4Aot9/lq T52+1T5c9zpoV9V9MDOM4RBcSwEWDDWhTKLSabJknmDrgOPzbXp4fw+6hd3pDiRHUk9upEpH 36aiIviUciP0b1TcGe1pxC9R7ABG27QDT208lbo5x0oKf1SrbnOTCKDAlGqbrqn9wPRsnAH/ qjMpNfBPHuaWPoBIZSxgX7H51fM2MXXsEZsssyH1iOvsXIIIv3sfGzSoeaGJP9VTI/Hm/vCH oKWzb+YM1G80CwQ3f9xAPcXnv8E3aPia6Y0JKqitT75LJ9RbGk6DJl+GhRzvv7WQFqo+gxYF Z0Jq/hn+eyuXS2lFy4nVlUBg==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY+dppI/YDqtuG9Eua4T+BrggU9K5C2fmAgAAjooA=
- Thread-topic: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0
On 17/11/2022 09:27, Jan Beulich wrote:
> On 16.11.2022 17:42, Roger Pau Monne wrote:
>> Currently Xen will passthrough any Local APIC NMI Structure found in
>> the native ACPI MADT table to a PVH dom0. This is wrong because PVH
>> doesn't have access to the physical local APIC, and instead gets an
>> emulated local APIC by Xen, that doesn't have the LINT0 or LINT1
>> pins wired to anything. Furthermore the ACPI Processor UIDs used in
>> the APIC NMI Structures are likely to not match the ones generated by
>> Xen for the Local x2APIC Structures, creating confusion to dom0.
> Plus we should have passed through Local x2APIC NMI Structures then as
> well.
>
>> Fix this by removing the logic to passthrough the Local APIC NMI
>> Structure for PVH dom0.
>>
>> Fixes: 1d74282c45 ('x86: setup PVHv2 Dom0 ACPI tables')
>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> albeit with the implied ack in there provisional upon Andrew accepting
> your response to his reply.
I'm confident that removing this code is better than leaving it present,
so I don't have an issue with the patch going in like this.
But, at the moment, I'm not convinced that this is the end of the
necessary changes.
~Andrew
|
