[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 17 Nov 2022 10:27:41 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TVo5WaeRDymC7yCopczXUzOTLCa5bghCYDb5eD8uuBk=; b=E8rt2nkxDI/xcwy1TOsGb9Pg78QT6gwE9yTxZ3lO4/IdJtkADPIjj2H163cqUGJ81eDcKJsz4PZHTbi33KMWTV4zig22UAl56nQrN9retnSLAt5bA72vRT2OOPDPuLoxzq3BdEXU2ySHyjNrrwcSnKnYRhauO6EgPw7fUz34K+pJzhnbe/vMQuNBj8eowcE8G4v5ssmGwJLwEtL9IsyFZCN4/A7t2+sZjQR5Kr8ilTym/fF3BDDYNYshCGH7Bdi9AbqMU8TANG9oyBrYX3ph/cP8qgDJGa81IuE1QJh/FCVaIVdtZn2TiwhtkKBg9/ljkXWFcWtxiZhvjQHhObsm/A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ky8uqcKQPFaAXClqnl3xcZ1Q2SlKn+qu3sOXpCMSmaGQ0iwUhQhKI09tWj8uVlwtBKSSab4m0yGfUxw4b/MOdqbV3DX7l3jaHXZ8/xGM3B8J8Nhht+V9ECkyZaX3uEFbIu18ZaroK31cx82T4xk4XhY2f7+Pdk0HuQvk2aaVertMFYrBkelHpPgb733q7vEQPm4cooGtVjvq55U4x1IZtINdfjQGTSkAu2PTNgw5d/nlfDy8I6ckmHhV29hGeq3Sdz4CvS6FfDSi1CxBNcQM8jiUj+8bRPQ6OKNFMuMRS9ymi1ZdgUm+cgVZKL9XMW4XpbvDuWtVn8kHXkFFznAhNw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 17 Nov 2022 09:27:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.11.2022 17:42, Roger Pau Monne wrote:
> Currently Xen will passthrough any Local APIC NMI Structure found in
> the native ACPI MADT table to a PVH dom0. This is wrong because PVH
> doesn't have access to the physical local APIC, and instead gets an
> emulated local APIC by Xen, that doesn't have the LINT0 or LINT1
> pins wired to anything. Furthermore the ACPI Processor UIDs used in
> the APIC NMI Structures are likely to not match the ones generated by
> Xen for the Local x2APIC Structures, creating confusion to dom0.
Plus we should have passed through Local x2APIC NMI Structures then as
well.
> Fix this by removing the logic to passthrough the Local APIC NMI
> Structure for PVH dom0.
>
> Fixes: 1d74282c45 ('x86: setup PVHv2 Dom0 ACPI tables')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit with the implied ack in there provisional upon Andrew accepting
your response to his reply.
Jan
|
