[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH for-4.17] tools/libxl: Correct error message units in libxl__domain_set_paging_mempool_size()
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Sat, 19 Nov 2022 01:45:56 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wd8mJ5zfR+79oWHkdqNzD1zqjctsNe0GXT3PlKrnKbI=; b=B4lIGlsE9lFtHcPT0gnXSmgA6NyrEb/u9287/4gafKvgYzYK+FiKig4qUQwaapyobp/jZ/acGTPFuG/yrT4WUyfyMgdu46zjdAHbu2H0/ujCF+YbK5Hsl/8af5o15J/5iVDSAhzidDvDlzW6iPCtVykwIAUy0mAx5hDMwLtGVxWbc6YqBkL0bJ7H2B8j3HlaBV//45Y3Aemu1s850R/7dNk3VmJryA06G6KJ68YChmwqS6USF3ErhO1c9Ov8hhGzNI8WHXzh/0vvJKwewwWXCRIr0NbOLa8C65CYdbBoqAJnVbiMe4KZkaV9mJcAgwvJ1juexHqUpa4JuxvFIuzrgA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MwU9/oKQRCHS5rwOBlDo7NLqj8nvQyY+DgeALunYXJ38xozsulbsrR9A9tw6MCICY/Kfgf07pgxlKRGAMHEsHlauz+bZQkd6R59kTKWSKdkcKJbVxs+pFN6HBjXhMo23xXSP0Kgy5JqaPP4AzY/BIcxo6AxqEUpu7kFu9n820T8x8OHbWcOCvUGSdsW9kDOIka1TjaKXPwEY7E+7s6olL2bgb5J5bXxWTKw2t6ghJj1lpfNVQQjDAXScfmATRFiBESkbbE4XJnV4tSoG3Wf9VOqqIJodla1mTp2lF4OFtyeUbciSNr3KtqjMvY360+CkPI1bpVL4iUpcSpKp7YaILw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Sat, 19 Nov 2022 01:46:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY+2+K+dbSE+6zIE6kpdVqzhxbFq5E7LKAgACNCOA=
- Thread-topic: [PATCH for-4.17] tools/libxl: Correct error message units in libxl__domain_set_paging_mempool_size()
Hi Anthony and Andrew,
> -----Original Message-----
> From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Subject: Re: [PATCH for-4.17] tools/libxl: Correct error message units in
> libxl__domain_set_paging_mempool_size()
>
> On Fri, Nov 18, 2022 at 05:02:13PM +0000, Andrew Cooper wrote:
> > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
> > index b59bbe00bb30..68ad9763b6ba 100644
> > --- a/tools/libs/light/libxl_dom.c
> > +++ b/tools/libs/light/libxl_dom.c
> > @@ -1459,7 +1459,8 @@ int libxl__domain_set_paging_mempool_size(
> > int r = xc_set_paging_mempool_size(CTX->xch, domid, shadow_mem);
> > if (r) {
> > LOGED(ERROR, domid,
> > - "Failed to set paging mempool size to %"PRIu64"kB",
> shadow_mem);
> > + "Failed to set paging mempool size to %lukB",
> > + d_config->b_info.shadow_memkb);
>
> Unless I miss read, `shadow_memkb` is also "uint64_t", so I'm pretty
> sure the format doesn't need to be changed, and we should keep using
> PRIu64.
I did a grep in current code, and:
In libs/light/libxl_types.idl, "shadow_memkb" is defined as MemKB, which
is MemKB = UInt(64, init_val = "LIBXL_MEMKB_DEFAULT", json_gen_fn =
"libxl__uint64_gen_json")
so yes it is 64bit indeed. Using PRIu64 seems correct.
Kind regards,
Henry
>
> With that changed: Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>
> Thanks,
>
> --
> Anthony PERARD
|
