[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17] tools/libxl: Correct error message units in libxl__domain_set_paging_mempool_size()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Fri, 18 Nov 2022 17:18:33 +0000
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Fri, 18 Nov 2022 17:18:55 +0000
- Ironport-data: A9a23:sapZtKgV1ujuzBsSL4rHs8twX161EBAKZh0ujC45NGQN5FlHY01je htvW22AOamJNGGgco1wbI209RsC78WEm9I3QAQ9+C8yEykb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5QaOzyJ94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tRAJAwoNSybudmH45+rSNNDl8cJDtD0adZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglH2dSFYr1SE47I6+WHJwCR60aT3McqTcduPLSlQthbE/ zOfpDygav0cHN6vxD+/9nCUusDOgiX+dag0EIW05PE/1TV/wURMUUZLBDNXu8KRqkO4QcMZF EUS9QInt610/0uuJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpVTA9nJZoH3pwj AbPxo63Q2w02FGIdZ6D3u+YkRbpBTArFl4hSD8GdyQU4PPBuZ5m23ojUe1fOKKyi9T0HxT5z DaLsDUyit0vsCIb60mo1QuZ2mzx//AlWiZwv1yKBTz9smuVcab/P+SVBU7nAeGsxWpzZn2Ip zA6lseX94ji5rndxXXWEI3h8FxEjstp0QEwY3Y1QfHNFBz3oRZPmLy8BxkgTHqFyu5eJVfUj Lb74Gu8JPZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPMguLlLaoXswPBb4M4XRfK4Ey/lX1 XCzKJfEMJrnIf4/kGreqxk1jtfHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrlR0U5FyS2Lm +ti2zyikUgGD7SlOnaJrOb+7zkidBAGOHw/kOQPHsbrH+asMDhJ5yP5qV/5R7FYog==
- Ironport-hdrordr: A9a23:rVl97ayjs/6iD3ERE5PEKrPwLL1zdoMgy1knxilNoRw8SKKlfu SV7ZAmPH7P+VMssR4b9OxoVJPtfZqYz+8T3WBzB8bBYOCFgguVxehZhOOIqQEIWReOldK1vZ 0QFZSWY+eQMbEVt6nH3DU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Nov 18, 2022 at 05:02:13PM +0000, Andrew Cooper wrote:
> diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
> index b59bbe00bb30..68ad9763b6ba 100644
> --- a/tools/libs/light/libxl_dom.c
> +++ b/tools/libs/light/libxl_dom.c
> @@ -1459,7 +1459,8 @@ int libxl__domain_set_paging_mempool_size(
> int r = xc_set_paging_mempool_size(CTX->xch, domid, shadow_mem);
> if (r) {
> LOGED(ERROR, domid,
> - "Failed to set paging mempool size to %"PRIu64"kB",
> shadow_mem);
> + "Failed to set paging mempool size to %lukB",
> + d_config->b_info.shadow_memkb);
Unless I miss read, `shadow_memkb` is also "uint64_t", so I'm pretty
sure the format doesn't need to be changed, and we should keep using
PRIu64.
With that changed: Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
