[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH for-4.17] tools/libxl: Correct error message units in libxl__domain_set_paging_mempool_size()
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 21 Nov 2022 11:01:09 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ylLdoX3quGgGcnv6snER42N6P7jvPC1rDvaK2FEHeVs=; b=gX9L6baJSriEVTm7Y/4B4X4DFvTyg36i04ptgQAC8jwruG8501prjbL/NpHaBY/8SuEHqZkYr3oD8z8FBeLEi2bofWfBCoGa5p1peltkIsv3SwRIYIW2cYjAyvv1ED6gdI2BJQ/NhKX0BeFxrQjtKnPKlvnxBNTc8ixO6JKb6B/yNsmladselO7+DfRMKbhlGP1QBJrc9d9s+9CFM8jyS0SWFkBgq4eIFunSe/HZFLqarCGv+4cxv04MKGYKfrfw+bDjNliOsfxW6Owi8W9/AaWDPiAYKqdXXa5V7Fd+jNrcjv0/YIqueQVxVdK1OwrGLhnXssX3CkZxp+3zs5RS/g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gIx1rZ5oFRYYjxbukV7Vl7//I7JC3aD200zA4XiBLg1/4tzpsvruR9TpjTUOgWeGKcIQHEpQLzzwt3guVj6026XVk+OoWLFJPM+zAwGGRzENryZqhDMafLuFl6ArM/lWM7+ozW4px1L8fXVpmDGX17c4NPxt3oZ3aWq23Fzo5xVVZb3U1OmJxwPwuxnCEqYpFS5+SFW/7Ly7izjPpymbTz+9znM3ZLcl2d/QUUxWZ2Z/1oygzgDtKBIDGIhXTzWSyhnX+bgnML10/2tOvehLe5bLXaYSMfQfkoCjmNI1XA3u5/6yAZ85MIX/1ODR34f6amwVUi3fhtxw1zrde01/mw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 21 Nov 2022 11:01:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY+2+K+dbSE+6zIE6kpdVqzhxbFq5E7LKAgARNc2A=
- Thread-topic: [PATCH for-4.17] tools/libxl: Correct error message units in libxl__domain_set_paging_mempool_size()
Hi Andrew,
> -----Original Message-----
> Subject: Re: [PATCH for-4.17] tools/libxl: Correct error message units in
> libxl__domain_set_paging_mempool_size()
>
> On Fri, Nov 18, 2022 at 05:02:13PM +0000, Andrew Cooper wrote:
> > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
> > index b59bbe00bb30..68ad9763b6ba 100644
> > --- a/tools/libs/light/libxl_dom.c
> > +++ b/tools/libs/light/libxl_dom.c
> > @@ -1459,7 +1459,8 @@ int libxl__domain_set_paging_mempool_size(
> > int r = xc_set_paging_mempool_size(CTX->xch, domid, shadow_mem);
> > if (r) {
> > LOGED(ERROR, domid,
> > - "Failed to set paging mempool size to %"PRIu64"kB",
> shadow_mem);
> > + "Failed to set paging mempool size to %lukB",
> > + d_config->b_info.shadow_memkb);
>
> Unless I miss read, `shadow_memkb` is also "uint64_t", so I'm pretty
> sure the format doesn't need to be changed, and we should keep using
> PRIu64.
>
> With that changed: Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
