[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/8] tools/oxenstored: Fix incorrect scope after an if statement
- To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 23 Nov 2022 14:50:12 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aaXdZiB9F/9O4yXuauqr9q4CaJgFdfOSj3tYLWiJoGI=; b=dYsw3Qd0k74GAUoyjJqZFAqZ93D+CQSZMd800MlXiILUZ9iuyfie+JV1k/VyrPo+wPy0OG/4En6lAgjrqxDehWR7mh8UOUhp2f+tnS+FDJgi+GMMC1+7ULD6uHpH3DpVveHKuOZqaLWPIdFzrc0VJ2eQavice0ckx1iR6SX09sTdNEf02WmzHaFg7VoNzHcqlP/1kMSvEEhhVJzBFBS2irikpBJ3KqalZ55fqH0HdM+jV2Vc+t4aky4WFoiwTqsZL12/F98gExhuFnr2hz+88tUsZWbaE1Nz2qzRcrYeiAxXWrzeuTRn6FRf3jufe4u7Z7AmFP/HBS599k7qZCELRg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P2MKZEuJD7tDBnlhW6Ago/jlLE7y2ydB01YN7DKdMy1iAeax40lrYt9TY39H887HhbN4vcgMxkT+xcjLD1oM0vc/dqRBpj24ISYswqg5wMgx9Xcpfm9FDwsQ8YCzWJlTmiEM6auyNR8vgPQZ2rqyTAJMIwoSqOMtxkuG3QFJ40Ti7Bf/nf9lWeXddwVVXS7HS0bo61xkLhNvh313DfZRuArt8x7v5LM3jYY5p1qNtHvuIk8SQSbwBTDLOtb56Gi5KMqzuyEMbtR+waUMZXcwWcyXZsgiFj1oiDJ6mott57eNYt8Bez2PcAUayGhoO8Evm5NpS+1FYisBjrAOJWtPCg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>, Rob Hoes <Rob.Hoes@xxxxxxxxxx>
- Delivery-date: Wed, 23 Nov 2022 14:50:34 +0000
- Ironport-data: A9a23:lSWyr638cAjf49ZMQ/bD5cxwkn2cJEfYwER7XKvMYLTBsI5bp2QFn GMZWWzQPqmJZGXzet0iYIu0908O6MOBnNJjSQY5pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVkPqgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfL0Je0 cQUcTcxdxWhwO+40fXkd7FwmZF2RCXrFNt3VnBI6xj8VK9ja7aTBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6KklwZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXOnBN1NT+DgnhJsqHqD3DcPODwmb2qUg8e7lkCyd4gBK FNBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQqvdE7bSYn3 ViIm5XuHzMHjVGOYXeU97PRpzXiPyEQdDYGfXVdE1tD5MT/qoYuiB6JVsxkDKO+ktzyH3f33 iyOqy89wb4UiKbnypmGwLwOuBr0zrChc+L/zlyGNo55xmuVvLKYWrE=
- Ironport-hdrordr: A9a23:pIjF16g5CYoN1oN+sL9ohIUvEnBQX/J23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu17h/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboXgTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp9KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wXh4SqbpXVd WGPvuso8q+QmnqKUwxeVMfmeBEa05DWituhHJy4vB9nQImx0yRhHFoufD31k1wiK7VDaM0p9 gse54Y6o2nBKUtHN1ALfZETs2tBmPXRxXQdGqUPFT8DakCf2nAspjt/dwOlaiXkbEzvewPca 76ISVlnH93f1irBdyF3ZVN/ByISGKhXS71wsUb45RioLXzSLfiLCXGETkV4oCdiuRaBteeV+ e4OZpQDfOmJWzyGZxR1wm7X5VJM3ERXMAcp95+UVOTpcDALJHsq4XgAb7uDauoFSxhVnL0A3 MFUjS2LMJc7lqzUnu9mxTVU2OFQD2KwXuxKtmuwwE+8vl/CmQXiHlltb2Q3LD6FRRS9qorYU B5PLTr1qumuGjexxe701lU
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY/oYHeahpJxrT+UW3puGtv+tGG65MmLsA
- Thread-topic: [PATCH 1/8] tools/oxenstored: Fix incorrect scope after an if statement
On 22/11/2022 15:20, Andrew Cooper wrote:
> A debug statement got inserted into a single-expression if statement.
>
> Insert brackets to give the intended meaning, rather than the actual meaning
> where the "let con = Connections..." is outside and executed unconditionally.
>
> This results in some unnecessary ring checks for domains which otherwise have
> IO credit.
>
> Fixes: 42f0581a91d4 ("tools/oxenstored: Implement live update for socket
> connections")
> Reported-by: Edwin Török <edvin.torok@xxxxxxxxxx>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Christian Lindig <christian.lindig@xxxxxxxxxx>
> CC: David Scott <dave@xxxxxxxxxx>
> CC: Edwin Torok <edvin.torok@xxxxxxxxxx>
> CC: Rob Hoes <Rob.Hoes@xxxxxxxxxx>
Christian doesn't have this email for some reason, but has given me his
ack in private.
~Andrew
|
