[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[4.17?] Re: [PATCH] x86/HVM+shim: fix build when !CONFIG_GRANT_TABLE


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 1 Dec 2022 17:05:07 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3NeixQF/EzehRq87VviXjYRM4B9SsJjwh7AvmqLUfpU=; b=UA55VyuET1625kpB3f9DXncUdULCZF6lnfhBy0ggUIGbPVh3S4k80LvVZIW2RjL3iRq6TlAabIn5cknkHsTpSV7X+NnuP4XEl8NDB6qoOEW8U/wwCeI3tmIlExhuNDkv+8cGnS+64Ry+hcHhN9XsZWzk2/bN/XLCt/OS0rqIvLF6elIwzXz0cwnbXFWsaJToYuH+nwpgBbE8vJWlmauVNv1RhaizG4xR+px5LuJ6genYu+I8m4dW8ev2dRydO2J0a/AMJ7srocvxuiqqxQcupuQeJFFVbTCIE+pR/h826qak93tdrYsgQZWlaG1mq3i3P6S6p6AUPWmlB7dM0TKqyw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XKlaBy5WOvaeYLIqVFLyefKPpcQefFuqqHXrZImsI40enuxdwuoSQslyMG+xL3BgBiISs4QuIQNX0czv/YZ2jExmlWPI1ygEsUaSHNAo7ePM5Xkg9RDLWq0LB/sQHVLAsymDGJP3kwneVZt0C1BuAqN0QObj6V09r8pfw8RhmZ2PjcYlCDPBhvoI+dpXiZAZvHREjHsFRcsPK3D1CEkt7nmAwkGR8zOC9HfXLo/wbzlUv8FYI+zrwIAw+oz3Gl22byJGM9w+IhlHTNDFqZjW1ntCUOEM1KtHPKHWTIPQvhdhJvDJYFkbtooiSPfhbfJqhkSrW4ifMOIq6O0d42jm9A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 01 Dec 2022 16:05:14 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.12.2022 17:01, Andrew Cooper wrote:
> On 01/12/2022 15:57, Jan Beulich wrote:
>> The HVM flavor of the hypercall handlers exists only when GRANT_TABLE is
>> enabled, while surrogate shim variants exist only for the purpose of PV.
>> (Also scratch out the Arm variant in that case; what exactly is used in
>> that cell of the new table row doesn't really matter.)
>>
>> Fixes: 8523851dbc49 ("xen/x86: call hypercall handlers via generated macro")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Thanks for investigating.
> 
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks.

> Thoughts about inclusion into 4.17?  This is a build time regression vs
> 4.16.

I thought this was odd enough a configuration, but since you ask, let me
forward the question to Henry.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.