[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [4.17?] Re: [PATCH] x86/HVM+shim: fix build when !CONFIG_GRANT_TABLE
- To: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 1 Dec 2022 16:14:11 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jFJM/T03TxyNEVVjKFFZOrrgzK6ufYoHZTBMSCT/bGQ=; b=edBnovFjeR5QqHMPKZK9mNebXJI+qr8PNanjUMMtuBwuOKXvgxN0/jg2AlMHzjDQzrmxCq9/fsaSKW2seWYQdYMoWW32I52xWuOuhorHkXide3OraG8YCs+TvPqitRMTWq7oDhmr+ez+4F9t9LNMa20DGrkhN01xp7JiaMTxC/6/9xX0B3Oi63XTAXFD4oKqcekSwjSpeFRyUU9MX3xiW4s6zM1SxF6PGx4UvREuYHXXaBVXDfB0n5k3gbHV7AxWK37buE0oPhcHErLopaqjxT1Q7QmPapDHC9AZc8kVMqYxWb+kIhqCwkqf5NdI5wP/1nnffF+10KpEWz+O+D8Sww==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iWyQnp6MVJ8MsBVTt4iRN3fx2i5TOaUJBwJbfTFSTyBa/Rf9FMUK+Zt6HslnUo/uXEIjR3H8jRR81lrjssG0NSWTqq0+GQk/KcQ4k0vG1LTUXIwnXV2cFVJCX0hMTFkGnLbuur9lqK5p61PST9vQijcBqDahCyUJrD1QrrGf6/4Z6y9k8NAf91DLtt5BQlmTgPrpsnJ+g2hxehqvNjXSWQ3vJppdqn79BvbVsfqkvElfBCXoU/a6Ek2whkwKM9YvhQ5zsNAIL+xZh/MeF9EG/JjYkmrxE/jYesUM4RYYvs8hoO4X62nd/G+rhmAd6rW3aANQlv/dcmbBxKskOwCRUQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 01 Dec 2022 16:20:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHZBZ20FNPkaUdVSkig9Y686gPD965ZMT6AgAAA44CAAAFewA==
- Thread-topic: [4.17?] Re: [PATCH] x86/HVM+shim: fix build when !CONFIG_GRANT_TABLE
Hi Jan and Andrew,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Subject: [4.17?] Re: [PATCH] x86/HVM+shim: fix build
> when !CONFIG_GRANT_TABLE
>
> On 01.12.2022 17:01, Andrew Cooper wrote:
> > On 01/12/2022 15:57, Jan Beulich wrote:
> >> The HVM flavor of the hypercall handlers exists only when GRANT_TABLE
> is
> >> enabled, while surrogate shim variants exist only for the purpose of PV.
> >> (Also scratch out the Arm variant in that case; what exactly is used in
> >> that cell of the new table row doesn't really matter.)
> >>
> >> Fixes: 8523851dbc49 ("xen/x86: call hypercall handlers via generated
> macro")
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >
> > Thanks for investigating.
> >
> > Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> Thanks.
>
> > Thoughts about inclusion into 4.17? This is a build time regression vs
> > 4.16.
>
> I thought this was odd enough a configuration, but since you ask, let me
> forward the question to Henry.
I think a build time regression should be fixed. We cannot assume users
will not use this configuration (as Jan pointed out in IRC). So for 4.17:
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
But if OSSTest is exploded after merging this patch, I would like to request
a revert since we don't have too much time left for the due date. Hopefully
everyone is fine with that.
Kind regards,
Henry
>
> Jan
|
