[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] x86/platform: introduce hypercall to get initial video console settings


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 5 Dec 2022 14:00:45 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WD601j0h9c8FpBj4o2zuup7BecZ07U/aFRWUX4aVJ88=; b=PF4sun4E/9tMS58q52Z/SUAb6WPoW0W+fSszloJzfDKPHKnuU0v8F0XCqnqgMcWMY6hu63ods+LjKqiXDa1QAlygnmE7SZcxsLohh/C787dvZG+sUfZrl6MeW7rcX4K1NzhpmaQ6OVtlUHQ241+50Nl0jz1lWfMRJJrTEgX+dd0nRcp93dp0sffrH2Y9g2Owdf2a8STHSkX3JUKxYRZ1+Swqm0sGzr4x7NbSdBOYLpmRWcFszFhTmDrvlyxa0wne02qB0zl03ovzArPcPbkmS3BFZJDfCNy+UtABuGDvoJDAO641gxRsFgaH/7rVeRsb2Ujf2V5nRB/3un1ulfuyNA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XUqLYdqCtiCJppvjjNdvxS9EqY6bfoKDttLnrhkSK2c3A2UBabEG83ZEOmLxPQFg36w+TdmpJeTkYOx/N0KIaPKY/AZVUfyss1yQivK1/2S5triAp2EhYV03doMxa1jqdR2sIS6lR9f2+YexSHonv4pTEtJbsLa9eNGHUEmoTkBDTznYGOkIThOd2v+gz1Bif/sV2k0PruKmt3VL6Rghvae5QkC8q0m1bXkKTsIbB3F+fgHlMXUGDw9jz/NBjmtXPYcUECs9pPM1dIRymjJl5sSe3t5FK1UzJLffUHDry3KfCpfAxDG/Zsm0o3aE4ZIOD78c9AAeZtWyL1CHNlQZEA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: marmarek@xxxxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 05 Dec 2022 13:01:05 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.11.2022 16:45, Roger Pau Monne wrote:
> This is required so PVH dom0 can get the initial video console state
> as handled by Xen.  PV dom0 will get this as part of the start_info,
> but it doesn't seem necessary to place such information in the
> HVM start info.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

I'm okay with this as is, so
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
but ...

>  xen/arch/x86/platform_hypercall.c | 11 +++++++++++
>  xen/drivers/video/vga.c           |  2 +-
>  xen/include/public/platform.h     |  6 ++++++
>  3 files changed, 18 insertions(+), 1 deletion(-)

... wasn't the goal for Arm to have the same interface?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.