[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Relocate the ESRT when booting via multiboot2


  • To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 13 Dec 2022 08:17:56 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9yumtuPumW//LbLdht9RR10lyRMsr8EqEVgTwNWOxl8=; b=Y/znPCEHvbTKJxNZXCzv1lQ0IOur05q7BvuJB1TlECntAkhjeETQsi7UqNvuz7ssf0TlKfRMq6lr0M42QAj9avhCoRuDskU8BhCDthj5Pp4cdXV01DvQhHdSLdjgDi6/jqvNbzRnYe4iuKmn4nsjDTJ3Km1NNdFo54qMMkjfB+mNFtBturZMIdIJVO3OynOoScMtNx4m+6x2HnuRXIB8FMN6Tr68GT2COb4R+5Gcsv771paw/uhNiplsGRNHgiGpHyAu2FqbRznmyqjSgPiKUzewztzlpsWFRfooVJnvZuGIM+ndgzLla9K2zXNs/i7a8XcnI0Pyh3oqA9v6KQoGmg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A98IdPjHJh1kw50IZhzxKpk4joOd/oh1IxkF8B5bSlwvliENk2emmSSuCRcjVzFtFloRRfoO3kGFpaWsKT9ftQADBSPXwz7DAxk48FKCdYMUouGlynBhkZL0vZORk2Lo/4C23V0XLd8FJ6i6JYtmEbjbvHqMDoAIH+/VxWq5B2fbtm+UV0jJmNCm2dM8jnF0jL+asa10cg+QjDgIfpYx8xSomom9u98HthfNOvQrSsiy3PkLMj4r5KJ/Mw9/h1ebCuPeGsakWLKCQ6RFE0dBukLxMoiRwiAMm+9eqYwJP7A6xUd0+jVbdQKAXKBDTn1FU/OSc9wKFfYYSmMyd9TINA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 13 Dec 2022 07:18:09 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12.12.2022 23:58, Demi Marie Obenour wrote:
> On Mon, Dec 12, 2022 at 04:19:21PM +0100, Jan Beulich wrote:
>> On 09.12.2022 01:52, Demi Marie Obenour wrote:
>>> This was missed in the initial patchset.
>>>
>>> Signed-off-by: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
>>
>> It looks as if, besides ...
>>
>>> --- a/xen/arch/x86/efi/efi-boot.h
>>> +++ b/xen/arch/x86/efi/efi-boot.h
>>> @@ -818,6 +818,8 @@ void __init efi_multiboot2(EFI_HANDLE ImageHandle, 
>>> EFI_SYSTEM_TABLE *SystemTable
>>>      if ( gop )
>>>          efi_set_gop_mode(gop, gop_mode);
>>>  
>>> +    efi_relocate_esrt(SystemTable);
>>> +
>>>      efi_exit_boot(ImageHandle, SystemTable);
>>>  }
>>>  
>>
>> ... this core piece, the rest is merely pure code movement, with the goal
>> of avoiding a forward declaration. If such is the case, please say so in
>> your description. I'll add a sentence to this effect when committing, so
>> the remark if for future patches. Provided of course it is true (i.e. I'm
>> not overlooking any tiny change) - please confirm.
> 
> It is indeed just code movement.
> 
>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Thanks!  Do you want me to submit a separate patch for backporting to
> 4.17, or do you plan on doing that?

There's no need for backport submissions except in extremely rare cases
where the backport turns out unusually cumbersome.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.