[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libxl: virtio: Fix build error for 32-bit platforms
- To: Viresh Kumar <viresh.kumar@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, osstest-admin@xxxxxxxxxxxxxx
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 15 Dec 2022 16:13:06 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FXBDkbfbYpCohXYacU2kjKm4zqPmNAkvFh77TK9mYWo=; b=DG4Xm/1FrVbZTZQJwlDmVNoa2lpZQ6nKMcjnRFHlErI3TLY7XydbMBn8l8E57RabLpJIHC44Rmfmf7eVQEUESl+qKZvNZ63n8dmayvpTLPDNfgSRthUgsZcty5itcIIH5qpv4KZXESZuarPd9jY8hnTGLobPdsnifrgRqvli3jHFd0XgNfKfYXWA6j0EBUJip6UDiljHHdrZ/SdWvwX5efHwbIGFq/QGtMrxF/tbYoHGcO8OMNY8yu8MVD48oUne9FBrEd4rIr9/0FUspLspkYNeeCUl2L1ipPkJy/hYy5dvwVt6OHLIR7QMppLbYnPNMlEDldnnVzj6XGn8nPm98A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NAKQ3l3ZcWUdhBgvJsJGfqVjjPKLaGrC53S1GI1fSvj+ynMBdF+IrlJlpgV1f7T9w7oHT7T2y0EYZSTSucmJbrPhN/5jVsieV7gLLvPHmA6Q1nnQV2/7i4lQRU+d4EJoVbtRdEgQrexENes/dUPToLp2IL4eR7g38VyRtICyrpAq9eDiePn5m2kdCATEirGo/Vg0DReaO2e2Kv7e6LTHTK1BybpSAWEFFK5aQ+BohQuhOcRcSfwBSU0i5czRw7UXusKeLYBsEtjUhki0UgKONPVF/qWe/MxgXp6W/MaZxmydEUlPayU4vrivay62M6VjKVKLzilhhipETo2i1+eCZw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Vincent Guittot <vincent.guittot@xxxxxxxxxx>, stratos-dev@xxxxxxxxxxxxxxxxxxx, Alex Bennée <alex.bennee@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Mike Holmes <mike.holmes@xxxxxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 15 Dec 2022 15:13:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.12.2022 14:31, Viresh Kumar wrote:
> The field 'base' in 'struct libxl_device_virtio' is defined as uint64,
> while we are printing it with '%lu', which is 32bit only 32-bit
> platforms. And so generates a error like:
>
> libxl_internal.h:4388:51: error: format '%lu' expects argument of type 'long
> unsigned int', but argument 3 has type 'uint64_t' {aka 'long long unsigned
> int'} [-Werror=format=]
>
> Fix the same by using PRIx64 instead.
>
> Now that the base name is available in hexadecimal format, prefix it
> with '0x' as well,
Which might better be done using "%#"PRIx64 ...
Jan
|
