[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libxl: virtio: Fix build error for 32-bit platforms
- To: Viresh Kumar <viresh.kumar@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "osstest-admin@xxxxxxxxxxxxxx" <osstest-admin@xxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 15 Dec 2022 19:01:53 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V3VKcMjIRGEKJPNQ+6p7LEBzYz+1/d2gpKP1yVXlq+o=; b=JrNj/hYrw5PPNJxDEBLYBi74mnA3hoRcK6joq/TgDJBdT7Nj4BN9YtQDUItVlDGXlyF+JMxCvxhIKyzKnu6gOoHP9W+nttcg3NWiiQHZ01I9uIty15EHDtuDNldeiMVxsr0iFkIRKbSHlVLwqiodVumNJFdfCh6DP1zUAA8PH7SgMvxoR70pF+EmZVVdhXVP39BgSWPTeh1nAbU6kYgCoR7ju/9TKakdMSXvqOypTEbcYBDEOieE4Ri1hW3tb74RREYx9P39Yw7ewtEdeNOu5WxqeGi+Y5pIvc4a+OQyAZH/GSwwqQq41RG4H6dvVtJdHWGaK80Jvh6wemyAV/i9hA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=drF4pW9k7T5PE2i+hP4+P9gDpcUe0a538AirmpLvlJ6m9IeX6zSiXETQJ0uGrXqNyqyFxxaaAWsRNSaDs0I0Uv3gcchAHFbfGHP+zXSnwX9otCmdnftZmBNAbzyh2MtAFZpbnOeSSvFJicB3WmEqp5fWmoME1rHz+g2Pb/et4p2eHGZ7592BgolfDFHw+o320yoFpVuPxnbNnhRCxAW4PVgg1JyEDUipHA1x8mHNHunDpGru1c/3vqFxB1ClYvwTp3AKxSDMOtGcfM/KnAGSL6wxMdZRJNOpHXjYHWY2agSpqembUPa0ZIutOMejXULSWvjy8owS7wb9lUds/1fKag==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Vincent Guittot <vincent.guittot@xxxxxxxxxx>, "stratos-dev@xxxxxxxxxxxxxxxxxxx" <stratos-dev@xxxxxxxxxxxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Mike Holmes <mike.holmes@xxxxxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 15 Dec 2022 19:03:39 +0000
- Ironport-data: A9a23:cKBSjqwGu74CqouuyQR6t+cWxirEfRIJ4+MujC+fZmUNrF6WrkVRm jBKXGiGa/yPMTf1f9l0aY3ioB5XuMLRz4I3TVFlqCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVkPK0T4TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWwe+ swJFgsWVyCKrLip2+j8RtY2mdt2eaEHPKtH0p1h5RfwKK9+BLX8GeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjWVlVQtuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAurCdpLTO3gqJaGhnWB5zcCUz4QfGLmiuOUkW+Oe+gED HQLr39GQa8asRbDosPGdwO5unOfvlgfRt9ZCcU+6QeE0K2S5ByWbkAUQzgEZNE4ucseQT0xy kTPj97vQzt1v9W9S32H8ayPhSivIiVTJmgHDQcGUA8E7t/LsIw1yBXVQb5LF7WuktDuBXT5z zWLqgAuirMLl8kJ2q6nu1fdjFqEuJnPRQMz+kPYQ2O58gRlTIqkYYWy7h7c9/koBJ2FVFCdu 2NBl8WAxOcWSJWMjzCWBuEMGriz4LCCKjK0qVdrEoln/Tmr/XOuVYRR5jhkIwFuKMlsUST1b UHavwQX/4NaNnauaa5xYqqhCsAry7imHtPgPtjRZ8ZOY5VsMheA/TtvaFS422HrmVIr16o4P P+zdMevADAaDqBiwSGeQ+Yb2KUsgCckygv7QpT2zA+7wKGeTHGQQLYBdlCJa4gR86essAjTt dFFOKO3Jw53VeT/ZmzS7tQVJFVTdXwjX8mu94pQa/KJJRdgFCc5EfjNzLg9eotj2aNIiuPP+ XL7UUhdoLbiuUD6xcyxQigLQNvSsVxX8S1rVcDwFT5EA0QeXLs=
- Ironport-hdrordr: A9a23:+TIrJqmZ7R6X23mS3KbZrpbuhBDpDfIc3DAbv31ZSRFFG/Fw9v rDoB1/73TJYVkqN03I9ervBED4ewK4yXcW2+ks1MaZPTUO0VHAROsO0WKF+UyDJ8SUzJ8/6U 4PSdkZNPTASXR8kMbm8E2ZPr8bsaC6GXmT9IPjJqFWPGZXV50=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZEIm2pBLpcrFxWUiesl94gtQKma5vTk+A
- Thread-topic: [PATCH] libxl: virtio: Fix build error for 32-bit platforms
On 15/12/2022 1:31 pm, Viresh Kumar wrote:
> The field 'base' in 'struct libxl_device_virtio' is defined as uint64,
> while we are printing it with '%lu', which is 32bit only 32-bit
> platforms. And so generates a error like:
>
> libxl_internal.h:4388:51: error: format '%lu' expects argument of type 'long
> unsigned int', but argument 3 has type 'uint64_t' {aka 'long long unsigned
> int'} [-Werror=format=]
>
> Fix the same by using PRIx64 instead.
>
> Now that the base name is available in hexadecimal format, prefix it
> with '0x' as well, which strtoul() also depends upon since base passed
> is 0.
>
> Fixes: 43ba5202e2ee ("libxl: add support for generic virtio device")
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
In order to unblock OSSTest, I've committed this with an adjusted commit
message, with the agreement on Anthony on IRC.
~Andrew
|
