Re: [PATCH v2 4/8] xen/riscv: introduce sbi call to putchar to console

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Mon, 2023-01-09 at 17:00 +0100, Jan Beulich wrote:
> On 09.01.2023 16:46, Oleksii Kurochko wrote:
> > --- /dev/null
> > +++ b/xen/arch/riscv/include/asm/sbi.h
> > @@ -0,0 +1,34 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-or-later) */
> > +/*
> > + * Copyright (c) 2021 Vates SAS.
> > + *
> > + * Taken from xvisor, modified by Bobby Eshleman
> > (bobby.eshleman@xxxxxxxxx).
> > + *
> > + * Taken/modified from Xvisor project with the following
> > copyright:
> > + *
> > + * Copyright (c) 2019 Western Digital Corporation or its
> > affiliates.
> > + */
> > +
> > +#ifndef __CPU_SBI_H__
> > +#define __CPU_SBI_H__
> 
> Didn't you mean to change this?
Thanks.

My fault. Missed that. I will double check that and take into account
in new patch series.
> 
> > +#define SBI_EXT_0_1_CONSOLE_PUTCHAR            0x1
> > +
> > +struct sbiret {
> > +    long error;
> > +    long value;
> > +};
> > +
> > +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid,
> > unsigned long arg0,
> > +        unsigned long arg1, unsigned long arg2,
> > +        unsigned long arg3, unsigned long arg4,
> > +        unsigned long arg5);
> 
> Please get indentation right here as well as for the definition.
Thanks for clarification.
> Possible
> forms are
> 
> struct sbiret sbi_ecall(unsigned long ext, unsigned long fid,
>                         unsigned long arg0, unsigned long arg1,
>                         unsigned long arg2, unsigned long arg3,
>                         unsigned long arg4, unsigned long arg5);
> 
> or
> 
> struct sbiret sbi_ecall(unsigned long ext, unsigned long fid,
>     unsigned long arg0, unsigned long arg1,
>     unsigned long arg2, unsigned long arg3,
>     unsigned long arg4, unsigned long arg5);
> 
> Jan