Re: [PATCH v2 4/8] xen/riscv: introduce sbi call to putchar to console

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

Hi,

On Mon, 2023-01-09 at 16:03 +0000, Julien Grall wrote:
> Hi,
> 
> On 09/01/2023 15:46, Oleksii Kurochko wrote:
> > The patch introduce sbi_putchar() SBI call which is necessary
> > to implement initial early_printk
> > 
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > ---
> > Changes in V2:
> >      - add an explanatory comment about sbi_console_putchar()
> > function.
> >      - order the files alphabetically in Makefile
> > ---
> >   xen/arch/riscv/Makefile          |  1 +
> >   xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++
> >   xen/arch/riscv/sbi.c             | 44
> > ++++++++++++++++++++++++++++++++
> >   3 files changed, 79 insertions(+)
> >   create mode 100644 xen/arch/riscv/include/asm/sbi.h
> >   create mode 100644 xen/arch/riscv/sbi.c
> > 
> > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile
> > index 5a67a3f493..fd916e1004 100644
> > --- a/xen/arch/riscv/Makefile
> > +++ b/xen/arch/riscv/Makefile
> > @@ -1,4 +1,5 @@
> >   obj-$(CONFIG_RISCV_64) += riscv64/
> > +obj-y += sbi.o
> >   obj-y += setup.o
> >   
> >   $(TARGET): $(TARGET)-syms
> > diff --git a/xen/arch/riscv/include/asm/sbi.h
> > b/xen/arch/riscv/include/asm/sbi.h
> > new file mode 100644
> > index 0000000000..34b53f8eaf
> > --- /dev/null
> > +++ b/xen/arch/riscv/include/asm/sbi.h
> > @@ -0,0 +1,34 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-or-later) */
> > +/*
> > + * Copyright (c) 2021 Vates SAS.
> > + *
> > + * Taken from xvisor, modified by Bobby Eshleman
> > (bobby.eshleman@xxxxxxxxx).
> Hmmm... I missed this one in v1. Is this mostly code from Bobby? If
> so, 
> please update the commit message accordingly.
> 
> FAOD, this comment applies for any future code you take from anyone.
> I 
> will try to remember to mention it but please take pro-active action
> to 
> check/mention where the code is coming from.
> 
Sure, I will try to be more attentive next time.

Probably it is out of scope a little bit but could you please share
with me a link or clarify in which cases I have to add Copytrigt(c) or
should I add a new comment with "Modfied by Oleksii ... ", or it is not
necessary at all? Maybe have I to put some other information related to
copyrigts?

Thanks in advance.

> Cheers,
> 
~Oleksii