[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] x86/vmx: Support for CPUs without model-specific LBR


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 10 Jan 2023 17:28:50 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YIVMyZpviGvd+DtKXNdgcxEVV4JpxCQF5jkJDsFuoPo=; b=SD+3gfL3bG2rmDnX2+k9MnMeQ2JWEy/o4qcOlnKjcxJvOjntBdeznBOItERC/lnUVruW2S56RkeCXovlNnp4Yz2lCexoxV1ghoNq01xGk9VsvIst9NIF/NR8Al0gUdOEcNLi9o53wSBz/c2LcL7yVkLwCLxZeSucwys+G13+9Y8ViHK5VS6NxeU3mv84pND0lv27IaDtpaxBIPQGPTrs/d2hN+oMbhpgALDg9Yuv7sAdntSd6f4ZzPJAPliM2OiyxKZoMIMPLoWsMxlM13fsz4kfVQ7RYcoP21Elsa0AfhmHnYw3sxZD/1vbBv2KZGEWUZ+4DJozo/nkuSx8zFRSCw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C8sPbhbivOcO48IZOunKrVoXUbPtEvavt5C2gCaqRRyQ5o+9QWHRmFMXU6nDVXju5a/GNiHl5eOsgt8Qsryl0tYN4jBZgyTfCthDxrNuUADebKQJJngTx8GFBTu/QgECT2a8zkiM49SWlvY3XJ7dz3fHji6R9Zs2KCyeQQKdJQugf6wYS/oyMHER8brc9BlywtqMgpHvPbddCw1KdIjAO8Ut+fPlTyfZSb7b1y7vnFYgLx0MvG94TEZKlupNX66n4oC7MnS0jwkP1NJPK/q33P7PuzL/lOKm9VEq5oJr3GyzUMCFuqDSNP9HGeJ3Pnx9v4P7tDBFSy3JmDx+G5KTWA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 10 Jan 2023 16:28:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 09.01.2023 13:08, Andrew Cooper wrote:
> Ice Lake (server at least) has both Arch LBR and model-specific LBR.  Sapphire
> Rapids does not have model-specific LBR at all.  I.e. On SPR and later,
> model_specific_lbr will always be NULL, so we must make changes to avoid
> reliably hitting the domain_crash().
> 
> The Arch LBR spec states that CPUs without model-specific LBR implement
> MSR_DBG_CTL.LBR by discarding writes and always returning 0.
> 
> Do this for any CPU for which we lack model-specific LBR information.
> 
> Adjust the now-stale comment, now that the Arch LBR spec has created a way to
> signal "no model specific LBR" to guests.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.