[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 06/14] xen/arm32: head: Replace "ldr rX, =<label>" with "mov_w rX, <label>"
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Fri, 13 Jan 2023 11:45:31 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E9J6x8qredz53eStATv7nQ4sBPEGPs+D2tq/zbtF/2A=; b=kuqpX078QN1k7tWNgwF2L7UFfTjeiTNZTJnbf9lRHifkmn0X66MIDIw649oXnOxSelUcXJtnjMY6Mt+bUgCxxDd8WGX0S6jHyqmkN9vAzKwufh+eQhKQTOqAERUgYimHeS9Jvj8/IDt0fnzctVevL/fGnYmbxQM388uS2ipqhtGKWRc3ZUZSNFyyoQh3u61q3rw5Usque8GcUg1lg38ImgXP4M2OumqUt7wAeFQlSWD7Mwor+6eDOdy68nXg5guZQEYfJUQ5AcTvVRhp7FlC3W7EtOU8vz4g+SRNUC8Bm0hqMrTb0485RWssQkwYZbXUgYipFlYnsSHOJeUUZ8UxKw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YIPNvKLW+F3LOwqzbRlMR++7ST4WDbxUeBqiLRjPinkjYzhoEwZ9SNTorRjyukA3Fu9si1M9rUzWOcQX/rn0GYRXU1UFdiGrqrBOmb8wO5KqcpAnOwTONE4FBUW/v+LagHW2VFl1iHhV1Lgkkj8HqtHxl7OcxPHXl0nEPPcZ8uY7lx+TUfDmAZsJJjCqTBlTQCAHSW10JdqO7Py9JLNi8lPO9Do5I2DESpVL+uWNlRHoRKmXmlbV3zEyjbR4C8bdw+wSdZjkLEcSjj622Q4UVGn0w8kHfyr4sSmL8MdoNwpxa/cLc6uqtZpUS00zy6tfMQPGUsOhF9HzmBbgitG6vw==
- Cc: <Luca.Fancellu@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 13 Jan 2023 10:45:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13/01/2023 11:11, Julien Grall wrote:
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> "ldr rX, =<label>" is used to load a value from the literal pool. This
> implies a memory access.
>
> This can be avoided by using the macro mov_w which encode the value in
> the immediate of two instructions.
>
> So replace all "ldr rX, =<label>" with "mov_w rX, <label>".
>
> No functional changes intended.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>
> ----
> Changes in v4:
> * Add Stefano's reviewed-by tag
> * Add missing space
> * Add Michal's reviewed-by tag
It looks like you forgot to add it, so to make b4 happy:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
