[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 1/1] build: replace get-fields.sh by a python script
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 19 Jan 2023 11:50:36 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jYpiYIbX/Y7DO5E2iQ+OsYPuSATLSttvJNKGLIObGSc=; b=cYaWG4oAOhQT78DoL8g2uMui4JtLOEoGXh2oehOyb9I5745i97EKyD0pozeGDHQFZMnkCbJreRNRPnsL+eHagkiCxEpNEyVZJokmLXpatnabN0IVYmnaayjvcOXRFabkcefuWQmtYKagY32vbdIparjcbpxgzzVSwklFoQ1EruWr6Ya5/Gt2qgKKBAwCFQLzZmtQ1PdqhE+cWPxiIwdbVj2SqKKOoKUcKvOuSdPNx6/ryArHGmMQyU3lsvTgtxuqyBH48niG3Va6Bd2u4e6yvVKK+MjJJrIbLyh0C57ZyNs0mT1RK+axtrgsdt0A0DZ85uzRDr+Xcr4JOKEl3KuP7w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BYqFeWdFfE9CkR9Y73vc+xoXjsk0Fwqi5VFS+HAFU0KLSBP+ICFjW/3UtZWJpu9LQF5d8jWYNgfWT2xJGVC8gVjoXP7iiEXyRJ/HEB5M/UQZzOLJd6y4Ck9V/Uowk9gzcBrMY+hLY4yZFlZHxuqLu3wPW2obK6NMn1XyeQLaiKcthIIPClrgcvJwt6F80bSH6OeZ5MhmS7Sh31fXGhw0hzFdaaHYsptpVVq+piWWmsQYfHbKLvarOgsU7nHX6+PqausjrMnMJD93VxkCac2M/zVnkT2M+3+MlypCq9KGBw8rVO66GPMcb18KYTSFonxlnW7/OvZiZ3X7YDJq6UNTGw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Delivery-date: Thu, 19 Jan 2023 10:51:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.01.2023 19:21, Anthony PERARD wrote:
> On Tue, Jan 17, 2023 at 05:21:32PM +0000, Andrew Cooper wrote:
>> On 16/01/2023 6:10 pm, Anthony PERARD wrote:
>>> +def get_typedefs(tokens):
>>> + level = 1
>>> + state = 0
>>> + typedefs = []
>>
>> I'm pretty sure typedefs actually wants to be a dict rather than a list
>> (will have better "id in typedefs" performance lower down), but that
>> wants matching with code changes elsewhere, and probably wants doing
>> separately.
>
> I'm not sure that going to make a difference to have "id in ()" instead
> of "id in []". I just found out that `typedefs` is always empty...
>
> I don't know what get_typedefs() is supposed to do, or at least if it
> works as expected, because it always returns "" or an empty list. (even
> the shell version)
>
> So, it would actually be a bit faster to not call get_typedefs(), but I
> don't know if that's safe.
There's exactly one instance that this would take care of:
typedef XEN_GUEST_HANDLE(char) tmem_cli_va_t;
But tmem.h isn't being processed anymore, and hence right now the list
would always be empty. Are we going to be able to guarantee that going
forward?
Jan
|
