[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 1/1] build: replace get-fields.sh by a python script
- To: Jan Beulich <jbeulich@xxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 19 Jan 2023 11:27:17 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NM5XKlfSWDVHdKp0gC68POdu2jjOPixbZWn1PSs/o1Q=; b=P4rT0uP0cxDb1FcoPpjhHmkpGBjkbg1PPl1xoRXJWwlU0a8m3TtD4VG4sT+uStdqorqElYrA+SWo3z6uLHNDgGy2LcSrZkpjmNn1nw4BHdo8dTVExOsbGf8sVXIlynnxEu8UVcC0WyFj03JT8xP5gBP9hutU/npLl+0tlgfbOayM02McVLbBrR6iWzLBQZO/VJNpJMGxeqJBet3v8JTnAxjsdstj20Ine7i9ixz+Ufr7QzOanJIwHAgbstXNhpNC0Det7QDIPZUPuKYq0Mwl+DOTjdrul0XAq5ReytbOY4WjAwHmq4RY8m+U5ZBNFztNqp7uAD/FUrj1z+kZHb4pgg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oTlnj/PwYhYh5VVwLD/1MXXgeCBA2kpJBM8cH7etT0mGg7N2cE4OXf+okKrvm3UdVos478yYnWPBDpGPJymp0JWYLnZ3L8iBulN3KkFvZoMKigHIiZhuZQTs5/hSW6fI0unB5wQ/OmUxLH3SkFt/VIZD66DjQE0dIKMGPH1LZTlVMwYJXZ7a6VmtbdHU1jFZmOzafV1AzC0tYEZtSW/V3tu+JP0p8kPKi17bCxb0QMZ2sPrCYmx+CHaQPiyx7mXPL0Dzal1FC9BiBf+zg2UIWARaw4BvQDfSxH1AJ04/3TqfcCnJQYPhfVxemE+m2Tffb3SSroLfUw/hURAOgd1GJg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 19 Jan 2023 11:27:55 +0000
- Ironport-data: A9a23:DK38X6hvnOX/lSpv2ILsspobX161tREKZh0ujC45NGQN5FlHY01je htvD2yAbPffZzb3LdglPNizoUkF6p7Smt8xSAQ6/3tkEC0b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5QaPzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQRGh0sSBW4ot6O+/Gfaep9t555DZf0adZ3VnFIlVk1DN4AaLWaG+Dv2oUd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEsluG1bLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6Rebip6A23wb7Kmo7MzorUl+B/9aAhEOZYPFCC x0N2AUoov1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+WsDezNC49PWIEIygeQmMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz FiisywWl7gVy8kR2M2GEUvvhjutot3MUVQz7wCOBma9tFohOMiiepCi7kXd4bBYNoGFQ1Kdv X8C3c+D8OQJCpLLnyuIKAkQIIyUCz++GGW0qTZS81MJrG3FF6KLFWyI3AxDGQ==
- Ironport-hdrordr: A9a23:CYx6MKH0LwEFYah2pLqFxpLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNJICPoqTM2ftW7dySSVxeBZnMbfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj3Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oK+RSDljSh7Z/9Cly90g0FWz1C7L8++S yd+jaJppmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjow4OyjhkQGhYaVmQvmnsCouqO+ixV42mJ 3nogsmPe5093TNF1vF4CfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqA/7I t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1bwKoVKuZFIMvJ0vFgLA BcNrCE2B+QSyLDU5nthBgp/DVrZAVpIv7JeDlZhiXf6UkqoJkw9Tpl+CVYpAZCyHt1ceg72w yPWJ4Y641mX4sYa7lwC/wGRtbyAmvRQQjUOGbXOlj/ErobUki946IfT49Flt1CVaZ4uqfaoq 6xGW9wpCo3YQbjGMeO1JpE/lTER3i8Ry3kzoVb64JisrPxSbL3OWnbIWpe2feIsrEaGInWSv yzMJVZD7vqKnbvA59A20n7V4NJIXcTXcUJspIwWk6IoMjMNor239arO8r7Nf7oC3IpS2n/Cn wMUHz6I9hB9FmiXjvijB3YSxrWCzvCFFJLYdznFsQoufsw39d3w3koYHyCl7G2ACwHtLAqd0 1jJ76imr+npACNjBP101k=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZKdXmSfLi4OljAEm5WNlNB2w+ZK6i3JyAgAGjEYCAARRgAIAACj+A
- Thread-topic: [XEN PATCH v3 1/1] build: replace get-fields.sh by a python script
On 19/01/2023 10:50 am, Jan Beulich wrote:
> On 18.01.2023 19:21, Anthony PERARD wrote:
>> On Tue, Jan 17, 2023 at 05:21:32PM +0000, Andrew Cooper wrote:
>>> On 16/01/2023 6:10 pm, Anthony PERARD wrote:
>>>> +def get_typedefs(tokens):
>>>> + level = 1
>>>> + state = 0
>>>> + typedefs = []
>>> I'm pretty sure typedefs actually wants to be a dict rather than a list
>>> (will have better "id in typedefs" performance lower down), but that
>>> wants matching with code changes elsewhere, and probably wants doing
>>> separately.
>> I'm not sure that going to make a difference to have "id in ()" instead
>> of "id in []". I just found out that `typedefs` is always empty...
>>
>> I don't know what get_typedefs() is supposed to do, or at least if it
>> works as expected, because it always returns "" or an empty list. (even
>> the shell version)
>>
>> So, it would actually be a bit faster to not call get_typedefs(), but I
>> don't know if that's safe.
> There's exactly one instance that this would take care of:
>
> typedef XEN_GUEST_HANDLE(char) tmem_cli_va_t;
>
> But tmem.h isn't being processed anymore, and hence right now the list
> would always be empty. Are we going to be able to guarantee that going
> forward?
IMO that's a code pattern we wouldn't want to repeat moving forward.
There's already too much magic in a guest handle, without hiding it
behind a typedef too.
~Andrew
|
