[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/5] xen/include: Change <asm/types.h> to <xen/types.h>
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 19 Jan 2023 16:43:07 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cE8PJXTR8azlFb4HPZRlTqqi/GSEat+IqwbKdSyrn/4=; b=hFlCuutq1kMGCK0U8+PICBCkd+exUwuHvd2aj31lmY/ioKO+gHsxearxCEPGqWz1ZxxI/m3VdKmqY4IgytIbAybuqD1T0NNIVgMJgU5RUofR+uLAiQH2+NrTaqrlhIeGfmnKw8mFzLEgA0gK7Pxt7D6u1hUuXqBS/vmKAaddhq7icdrndObze6r4tO0EZc2ro17M3v9qMbzOK1/0PPU4ais3Akp8juoUsvvk06gnADk7VpxaIJ9jJIj40h9EmhtkvlnamdplseAZw1rkPhQ/EDpH48YoBID3gkSDwbfZyzzlqFQ9baLpWEpmSY7hpwkVYa38jFUTArnW1s5cTHkt7Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xls2QcxJtViABrhpSwSIzTWxQe4833aOgEZ+q6Mq68AQRyPdh9PdeJfrDafIcbQOJSgc3UZvuETEP0odxJ6yuU4/7UcEcfUFjh7l7Aynh0isgN85eXLQL6R0am+fQqbxCEdUfKyRDRCKm4in3J/p3q1IJ4WW6j01x+2fLQDih3brpw0+iucA/aHoxEfyQRKu5lDOS1arL7n4IOXDEx3+5L9aIGRwFULV7egFw7iIhKIrIkQ3MtNGuNF8sypFD5rGwrv7yhhE189imjMz8gqsf63JLUtUd8NfEbcj7//cVR/D6DSS8i72gzPv+ZB33YE8weI87gTuvYlihAX9CkLwBQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <julien@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 19 Jan 2023 15:43:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.01.2023 15:29, Jan Beulich wrote:
> On 19.01.2023 15:07, Oleksii Kurochko wrote:
>> In the patch "include/types: move stddef.h-kind types to common
>> header" [1] size_t was moved from <asm/types.h> to <xen/types.h>
>> so early_printk should be updated correspondingly.
>
> Hmm, this reads a little like that patch would introduce a build
> issue (on Arm), but according to my testing it doesn't. If it did,
> the change here would need to be part of that (not yet committed)
> change. On the assumption that it really doesn't, ...
>
>> [1]
>> https://lore.kernel.org/xen-devel/5a0a9e2a-c116-21b5-8081-db75fe4178d7@xxxxxxxx/
>>
>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Actually I notice we have more explicit uses of asm/types.h, and
hence the title of this change isn't really correct (with this
title I would expect all uses to go away underneath xen/include/xen).
I'll try to remember to adjust the title when committing.
Jan
|
