[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools/symbols: drop asm/types.h inclusion
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 20 Jan 2023 14:19:06 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2VvP7C/TUCj9ivO2/VCWsZ8mJIl1GyIGDFOXUDq6QEA=; b=JLik6hkL04BMxpwy0tMHYsqIrQyrgzfCu+8l+n3qHOD2R4+eUv+Dsj6h9mpqUExeRnLGNyzFbGoPfaESiO3O54xIiYdPYL3wAcZNwIw+ze9VuU1+8N4hVv2XNI9UcF1l6QIXNFjqMeOxmuNE4yzj4EAMM5S0lIasPkQCx88/RxezdpGEIMG5gTG8qiBBAVOQX1Go0pFyOY8kmHQjnOsmpJFE/KA+zu4iNBT9VxZIDmjyWO7I4k9E9SDzQXGX/+Iq8V/VK+DtO5xqK8lSonaDvO8uLHJtxu9+qTOXa9u4B4CjZZC4y5IegBZZLkiT3O5+BVB9bwk8cwyw7qzZ/SSjKg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GBDrQSemKOQvkUTJrgHyPwg357HeTprP9W3rM20PNKJsp1RqhwGNvEKW9y0A8/eJQl+oxZD/fOGnj6Jn81LX6ZHtVJKlqG4cDf1Ti7TuOGLTHNqO4fDbSZsQ+uNimpHZNUYXUNgpbU2WSg2j3pAGhcMDEo45wJJHVfjYSQ6hgL4ATZLGyMZqSHirMWtAma74aUrWq4KXYKZH3h3BuVPSWiRsFaeAh9Oi85K6b7LeYSgy9QgqG3ftuCx6XoX1Ca2nQmPpDuTDWiFfWvae+07QE0iNRoOxv6RybMPzMdZWggbXukKWxBkYfUvbLz+F6jwyOr01Wem6uW5ng/ODMEBl2g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bobby Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 20 Jan 2023 13:19:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.01.2023 12:24, Julien Grall wrote:
> On 20/01/2023 08:40, Jan Beulich wrote:
>> While this has been there forever, it's not clear to me what it was
>> (thought to be) needed for.
>
> asm/types.h used to be directly included in assembly x86 file. This was
> dropped by commit 3f76e83c4cf6 "x86/entry: drop unused header inclusions".
Just to clarify: The statement in the description is about $subject,
not ...
>> In fact, all three instances of the header
>> already exclude their entire bodies when __ASSEMBLY__ was defined.
>> Hence, with no other assembly files including this header, we can at the
>> same time get rid of those conditionals.
... this further aspect. I can certainly see why the guards may have
been there (without having gone look for when the last such use may
have disappeared) beyond the bogus use by the tool.
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks.
Jan
|
