Re: [PATCH] tools/symbols: drop asm/types.h inclusion

[Julien Grall <julien@xxxxxxx>]

On 20/01/2023 13:19, Jan Beulich wrote:
> On 20.01.2023 12:24, Julien Grall wrote:
> > On 20/01/2023 08:40, Jan Beulich wrote:
> > > While this has been there forever, it's not clear to me what it was
> > > (thought to be) needed for.
> > asm/types.h used to be directly included in assembly x86 file. This was
> > dropped by commit 3f76e83c4cf6 "x86/entry: drop unused header inclusions".
> Just to clarify: The statement in the description is about $subject,
> not ...
>
> > >   In fact, all three instances of the header
> > > already exclude their entire bodies when __ASSEMBLY__ was defined.
> > > Hence, with no other assembly files including this header, we can at the
> > > same time get rid of those conditionals.
> ... this further aspect. I can certainly see why the guards may have
> been there (without having gone look for when the last such use may
> have disappeared) beyond the bogus use by the tool.
Ah! Thanks for the clarification. I indeed misinterpreted the first 
sentence.
Cheers,

--
Julien Grall