[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN v3 2/3] xen/drivers: ns16550: Fix the use of simple_strtoul() for extracting u64


  • To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 23 Jan 2023 15:01:26 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zg3tA51WWHVgY5PJgKh3Scq4U5zGBLMhgrhmUUHFOTM=; b=BzB/xT0hPUFD/GZ2lCAySFzohTQekAkndkW0hGBKaHUgJlLyZmeAOX0y2QO6B6Cwo1bsWmjcbbsQPXTsm1IoDTpeovk29XGLSvkILNZGmw+3H/OKbeE95Vr5PyJjlzfS2IbUY7Y7M+dyoJpyTnxjNOgrPgUJpXRT69WTro92GrHfXSZu0cL8rs6fKzfN9R4wU7X1TpW81a6mj94UQ0f025zkUxEmvmc4Dc7YeJ0P0y/dYrsZSo8AooyG39QAvvsiuajsxaJ1E8M9W04VX9TUVN3Jh1q7SC9Mt9a8ML0mHZ9s6u01/spd4N5owxGXeMMIqCQO6fqYUb75k1t0zgNksQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NmkEABVz5v2yH9EU+0uKHsdqxlyxeIjF+Zlj+ScVyVW/R6xbIzgvUIftIJPPwPxSjlKvpLxZs7RRAnSB7DA+k0TpyE35Nd/6solph9v1Eh8l6lH7M/QiaUZUWTDMoXTYSdT2PsWaKP0UeuPJUWmTzkxK/34D/k8yPhRVszr++3kydBBtVuXdvGdCgz9cPrekegFSCVzTdBQJso7gIZanjYhcRt+DUPsi7dkOJzYoMsDLtiZID9AfgKkWkJTsKH70rCyGvKoO6rJbg3TNM75A9DsDpem0t2363Fof6McCyYWnAk4H+UfUA6jVZ2dCzUMRv+JNiVkCdmq5p9bOLNxaVw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: sstabellini@xxxxxxxxxx, stefano.stabellini@xxxxxxx, julien@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, bertrand.marquis@xxxxxxx, andrew.cooper3@xxxxxxxxxx, george.dunlap@xxxxxxxxxx, wl@xxxxxxx, xuwei5@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 23 Jan 2023 14:02:04 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.01.2023 14:44, Ayan Kumar Halder wrote:
> One should be using simple_strtoull() ( instead of simple_strtoul() )
> to assign value to 'u64' variable. The reason being u64 can be
> represented by 'unsigned long long' on all the platforms (ie Arm32,
> Arm64 and x86).

Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
(or Reported-by or Requested-by, to your liking)

> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.