[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 04/14] xen/riscv: add <asm/csr.h> header
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 23 Jan 2023 14:57:20 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AbeJmVZ0cCLkW+0jH6dPO/xtZoCyvfpomQkDuJawSRQ=; b=ljEtOPtD75y/zQycW3UW31RKynesektnPMFc3e5In4arQQzeNhH1vmna55selhlJTlo1Q1e2kuWZpptGFN+zEWq8+D/tLVRQoR7+VOIeYu3FvdMr4toDrpm5RXc4hWPejHcaeSZZ37U1BfUVB7Dl2oQOjZ7m1i1FWAiobEBC/PpsgMSd/69te6ApajM8JcVvnZbuZB3DE70BfAgUHatwWe4Pj4+caRoD/LZcW1Bs4lQNBFxUCn9aMBNgsOfkc4GupKdSajTF1ekiEQjbvQCUZrbvrV1HDGpVfaFt5vM4T8dznlFlpt931xnIUUGT5tsSHTDqbkflHI32n/r1s8G1eA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kp9FHepyeZFiE5J8gJiuUVNvzzqMg3CgDP5ja4ZUe/+0rfwXGQ/2MzSMDQFsA+n0i6oDNc/uUpp3lfPbH5F9nvjUEp4RPOsYnnUy8xmAUsBIrLhzrRMwgUFDRNHoehjattnLxrwBBnmkHmJMxPLN+5oW7KuQObBpnYLjAceYJJ8rpaXo3KpRBp+9vFrOwh9XcPl6tAi9Cm6hpHCZgZZQJdGygyLI4SUZfp8j3tq/UHaMTnRSkaoTjnLwiwwQMJVqu3e8Bmz+kfx2uu31jkRjl6VtfuJmsuvlT/BAp8iDZcGCbRRbdHaKd9DmFKaOCU7Cljbf1jXM4K54wNhbWSsfXA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 23 Jan 2023 13:57:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.01.2023 15:59, Oleksii Kurochko wrote:
> --- /dev/null
> +++ b/xen/arch/riscv/include/asm/csr.h
> @@ -0,0 +1,82 @@
> +/*
> + * Take from Linux.
This again means you want an Origin: tag. Whether the comment itself is
useful depends on how much customization you expect there to be down
the road. But wait - the header here is quite dissimilar from Linux'es,
so the description wants to go into further detail. That would then want
to include why 5 of the 7 functions are actually commented out at this
point.
Jan
|
