[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen/x86: public: add TSC defines for cpuid leaf 4


  • To: Krister Johansen <kjlx@xxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 26 Jan 2023 10:57:01 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0u+EaJubThqqUuPcnofIEnkd2+LmR9QAnIGiAZG6LQw=; b=DRA6QNuW9+D3D+w9ARLAJVXPKpvYC826N6WT+N8YyvX9QSkjREbRpEZzXbbqdJA0Mfhg9eyoAEsrmcQcSOHCruGYaHsNEO/Rz1cRDMfJc4u9SRMTn4Ap3Ze2SXIJ+VFeob4lKNLc0B6jYVOdEusdJVo2TkYmqkg2K/Ia/K8qbqQBIaqf2IlHWLC7xjc1ang3p4o4U92wMffneTn36hNFC+QrZUOMM1BMn5foS2OCA3M61B7y0nA9rPuYcHtpyAOj/TVaYEVko9OUMTWRRoWhheffsZFGW/tY/ZdW9GUNnV4GRBDs1crUsFhfPEehqaNKSM0kS1YWZpPzJ2omDf9SKw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MmZuvCnnBRPr9tyXCAabttiQSspZplr43yea8CiTEhD0JI5ldq9cpg/A7NCw9YpV/hdQ80QEQfoBSMqDqzI4uluTwbmIDQkCl3MPR4B4KUgCjxN2B6ulc7uHt3ZWPbKMOhycBBDByzAVjmo9+wyo//KSkUihGMbug7RhPbqlT/K6S1iGbJwDyvtjyF/cNpFa1rSW2IaS2X5O6AQHV3apXQ+mI3slD28cXg7+NU4o0uuR31MmHNLMjuAVl36BmTA4LxRSEur0myUbHk4cffLcfQTZCSce5qxh1RNkPhe53mhPw8gZwIAdOLyHB0J60QTllJhniL9eYcle3V+pfU5B/A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, David Reaver <me@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 26 Jan 2023 09:57:19 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25.01.2023 19:45, Krister Johansen wrote:
> --- a/xen/include/public/arch-x86/cpuid.h
> +++ b/xen/include/public/arch-x86/cpuid.h
> @@ -72,6 +72,14 @@
>   * Sub-leaf 2: EAX: host tsc frequency in kHz
>   */
>  
> +#define XEN_CPUID_TSC_EMULATED               (1u << 0)
> +#define XEN_CPUID_HOST_TSC_RELIABLE          (1u << 1)
> +#define XEN_CPUID_RDTSCP_INSTR_AVAIL         (1u << 2)
> +#define XEN_CPUID_TSC_MODE_DEFAULT           (0)
> +#define XEN_CPUID_TSC_MODE_EMULATE           (1u)
> +#define XEN_CPUID_TSC_MODE_NOEMULATE         (2u)
> +#define XEN_CPUID_TSC_MODE_NOEMULATE_TSC_AUX (3u)

Actually I think we'd better stick to the names found in asm/time.h
(and then replace their uses, dropping the #define-s there). If you
agree, I'd be happy to make the adjustment while committing.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.