Re: [XEN v5] xen/arm: Use the correct format specifier

[Julien Grall <julien@xxxxxxx>]

Hi Stefano,

On 25/01/2023 21:09, Stefano Stabellini wrote:
> On Wed, 25 Jan 2023, Ayan Kumar Halder wrote:
> > 1. One should use 'PRIpaddr' to display 'paddr_t' variables. However,
> > while creating nodes in fdt, the address (if present in the node name)
> > should be represented using 'PRIx64'. This is to be in conformance
> > with the following rule present in https://elinux.org/Device_Tree_Linux
> >
> > . node names
> > "unit-address does not have leading zeros"
> >
> > As 'PRIpaddr' introduces leading zeros, we cannot use it.
> >
> > So, we have introduced a wrapper ie domain_fdt_begin_node() which will
> > represent physical address using 'PRIx64'.
> >
> > 2. One should use 'PRIx64' to display 'u64' in hex format. The current
> > use of 'PRIpaddr' for printing PTE is buggy as this is not a physical
> > address.
> >
> > Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>
> (I checked that Ayan also addressed Julien's latest comments.)
They are indeed.

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall