[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/12] xen/arm: add cache coloring initialization for domains
- To: Julien Grall <julien@xxxxxxx>, Carlo Nonato <carlo.nonato@xxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 26 Jan 2023 13:05:50 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lgkh4n+3WNdn4C0TtYi6Ty1jSE4VWSqbFzvEfXccjvQ=; b=RL+YalR5zrICOwUR19w4QcWGcdHang2zsaCYs+kVcCIBHInYDgocxvAE+1uO2C4mcQ1kvLYPmnYh2Bf0ADKH2ZnUOHMntLS1AX9x+bqT3GuCu1JyK0j2xlxAbDsMNyRTePEt7DJ9zqt/+JJkhNx7w+KB864VHbJo27+54MODpFbk6hvxmVaEsM9J8ZSWS6x9aAn7ZNfyMgks8lVKhVn5WR3G4bDEsIm5t0CkhWEBuMkNEdFHu12uyFXn3UvgwG86C6tl/Kwkxj94FrDxZx5Gpwsu3P14arhLm1OLHwb1g4ZY2su0gSXv7NoiJGfYKbggSvd10eu1N5kLPgTvQF5RZQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U59pi/IFyxkp89gNnR45EgeJgf6br5cm0nD0wXFYIdmvy5oRxYb0OTITB93C7B7Mun4gEJ9IJhowBKWpYHzwP2UpAsi0ZFCvJk1NmUtLoCRqDv24rL987yJsjLr43ujMPrjFtKeyU34L0G4PJoGazUynqvrH0JKXC5ZddxzBpyKiNUx8qx+GQul8Ike/HapQMt9VP/6txHavEizNdnapY3Xp3CKreAA8FqlshQqMMDFDhGf0hpgYnc2Spz+AeooyMQCSoLuLarcqyUXDMSR8+7LK0N+t9gJ+PvD+OcgJ/PDz/D7UBr/ltVH+RkT8qiuTpXhUc30iLZrH9ZZY7t3wPQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: andrew.cooper3@xxxxxxxxxx, george.dunlap@xxxxxxxxxx, stefano.stabellini@xxxxxxx, wl@xxxxxxx, marco.solieri@xxxxxxxxxx, andrea.bastoni@xxxxxxxxxxxxxxx, lucmiccio@xxxxxxxxx, Marco Solieri <marco.solieri@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 26 Jan 2023 12:06:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.10.2022 20:02, Julien Grall wrote:
> On 26/08/2022 13:51, Carlo Nonato wrote:
>> This commit adds array pointers to domains as well as to the hypercall
>> and configuration structure employed in domain creation. The latter is used
>> both by the toolstack and by Xen itself to pass configuration data to the
>> domain creation function, so the XEN_GUEST_HANDLE macro must be adopted to be
>> able to access guest memory in the first case. This implies special care for
>> the copy of the configuration data into the domain data, meaning that a
>> discrimination variable for the two possible code paths (coming from Xen or
>> from the toolstack) is needed.
>
> So this means that a toolstack could set from_guest. I know the
> toolstack is trusted... However, we should try to limit when the trust
> when this is possible.
>
> In this case, I would consider to modify the prototype of
> domain_create() to pass internal information.
Since I was pointed at this in the context of reviewing v4: The way a
clone of domain_create() was introduced there is, as pointed out there,
not scalable. Imo the prototype shouldn't change unless really needed
(i.e. benefiting at least a fair share of callers), and clones like
this one also shouldn't be introduced.
Hopefully this is all moot now anyway, with - as it looks - there being
agreement that this won't need to be part of domain_create() anymore.
Jan
|
