[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/12] xen/arm: add cache coloring initialization for domains
- To: Julien Grall <julien@xxxxxxx>, Carlo Nonato <carlo.nonato@xxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 26 Jan 2023 13:07:59 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oicwn2j9Il7hRUshoGUBWA0bFha8kNNLdMZO6PpzwG4=; b=Mq+StqAB0mgs64uGPVDgiXM0vKvbBJGZNHP0ES0CK87+Bm4GNs8BU7Whf2l/wWZGpPHQL/uGZEiJSKI05gaZwomlGPT537AERsJwsaZ0rZvOpj1M3SDfP4+ef6xLpdrv78IfIzhlu/JUeRtmrGhpT1blxJN1lxnm1VjNwYOEgUGOpjU1dFEDTp/2J1I3qfYb6vKCd51I9pn3W08t7FiS1QBcdRKPhUcleY23+urOrk5QTuvfINKK7Wu8UpUjz2V9a0koaf/GnT8FqKNyTwOtV41/njDODPre3CnVHppG/1oASfc7U9LVRsJHYi433cp+vz0Ijul+KbqjQ0S9nTzXgQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EVgjPFRpbqZoSB1YAWpH57dwTeqQSLBBLndWcQ69wtLydByL+xPeDeOawS0ujUtM2pSgkNQvzVnb41hzbLDgjVQ4cSsMH5rpAj6LvggsPJ89z74aV0inX09GRMJ8nf9O/74D1KLwXgII1wAIqXNBrqvGCRANK79XlHlhtheXdCw91+nBAoRIR7zcVG5hN5bQsoDJFUpw3kKA5jzTUuwIIye6zG+pHrWBg/tjB112we1Xcs0rYbjXnZBEReRbyJA3c3YJdN4ouZ5MluQvUuP1jjYh/7LSfOL5hYiE/GRhD+6ox792wbHr+/xEKG6OSf4e/y05KHWwg2cBz7hRmCnpxA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: andrew.cooper3@xxxxxxxxxx, george.dunlap@xxxxxxxxxx, stefano.stabellini@xxxxxxx, wl@xxxxxxx, marco.solieri@xxxxxxxxxx, andrea.bastoni@xxxxxxxxxxxxxxx, lucmiccio@xxxxxxxxx, Marco Solieri <marco.solieri@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 26 Jan 2023 12:08:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.10.2022 20:02, Julien Grall wrote:
> On 26/08/2022 13:51, Carlo Nonato wrote:
>> @@ -335,6 +337,12 @@ struct xen_arch_domainconfig {
>> *
>> */
>> uint32_t clock_frequency;
>> + /* IN */
>> + uint8_t from_guest;
>
> There is an implicit padding here and ...
>> + /* IN */
>> + uint16_t num_colors;
>
> ... here. For the ABI, we are trying to have all the padding explicit.
> So the layout of the structure is clear.
>
> Also, DOMCTL is an unstable ABI, so I think it would not be necessary to
> check the padding are zeroed. If it were a stable ABI, then we would
> need to check so they can be re-used in the future.
Independently of the other reply, a comment here as well: While domctl
being unstable does permit to omit zero checks, I think we're well
advised to still have them. The we can re-use such fields without
needing to bump the interface version.
Jan
|
