[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 3/3] xen/arm: Clean-up in p2m_init() and p2m_final_teardown()
- To: Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 27 Jan 2023 11:15:29 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E9lgnEcGVC/efddQ/CrfPikrjF0gpC28yMH8eiTwciU=; b=Onh/tBDJ0QB1IBALYxkrxdTuBkf5K4gk8krOgCsDYBbFfBVJ48izWXSuFhLENTuv5EZt7J5+J33psP1LPsgCOHmwRYNe2lWbEEBZwUrA18Cseds5wesfjdsFy7VnRfIwpB3fOz3OEY7X3ciEn6G6PRCMmFP4cjrRIlSIIdXcDvHdOVOwMJl+oRKrGoCUeu5APt90QXhh+CYeYTq3wC9TVZMVJACK85ofd8by2EDIR1jgZbM5L4BGgVhSklxHHyNRRCa6jXCXhL0tJzHsk9cbqQCWAvKgGyVUCY7nG182ZxOMJHeY1SKo+vIrgzOH/l4BktqO9YpADL2ia7mfpgUqzw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=btGH44JcsbuPIVD7C9278no175282NuC+pajB8hofCkc5FzoVJ9gPtqpH3ySUNAaE1zORFe2IjUihzzVHXY7848uoZhb+KwVUetrfCsuqkOW3q/jB6UxzxDZr2X6ks9r3denjnR3drbSSY9B+lHNR5U0ItXKvnFKMc3SugnejvJqoa5YwCqcpKSDNhlXQrItCzqDdf77bGH7kh/oyLetNr8fPM7hudPASp2DQqNiLGrVsJaWEjlxlvkoh8p69oL3YPn0Vn3WF5NY4EoSpT5mVLFdoJcTppkdSk3drwDbdMTKfT4j/eYDqv11dCGQjFKVt9NaZQPcsr1gctSi6ctUJw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Fri, 27 Jan 2023 11:15:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZKU4fKh9kG5Xa7kmVEqYgCVpcz66nH76AgAbPKgCABD7DYA==
- Thread-topic: [PATCH 3/3] xen/arm: Clean-up in p2m_init() and p2m_final_teardown()
Hi Michal,
> -----Original Message-----
> >>
> >> - BUG_ON(p2m_teardown(d, false));
> > Because you remove this,
> >> ASSERT(page_list_empty(&p2m->pages));
> > you no longer need this assert, right?
> I think the ASSERT() is still useful as it at least show that the pages
> should have been freed before the call to p2m_final_teardown().
I think I also prefer to have this ASSERT(), because of the exactly same
reason as Julien's answer. I think having this ASSERT() will help us to
avoid potential mistakes in the future.
May I please ask if you are happy with keeping this ASSERT() and I can
carry your reviewed-by tag? Thanks!
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
