[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] xen/arm: Clean-up in p2m_init() and p2m_final_teardown()
- To: Henry Wang <Henry.Wang@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Fri, 27 Jan 2023 13:10:17 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KwET6Q0cQdmE55vZ5Tz3o/6vpgzks292IFq2syxY+R8=; b=d9tDrizP/ONrlfzyLFKSkuGdvP7RD7R/yBhh/rw/elMYZCHmU5ds9fS918V6VCKVsJz/RW7+YLewoq+oaim+B3GHSFaUU85sqiJ3Ymz8pQzAYJn+PSu/2ONuPxeX2UaLB4vitzDMfaVJD2IpjqiiPeux2VxQx16Q5/VCZ52GU7UQnaZdZOpKcopKXyeg0VQPdSXRMz/17rmN09BeubY0RA095VdkgNFd9KVd4/0gmT6w2B+Cch7HDhzMRIIC64948TdUBxHOF+fwZvebffyu3U2A1zfJdOXh6gA/h7grguQeOlIFM4jhSAW3BnJz4a8cqlbgj+d5/P3dXDMoMChU/g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WzW9EMgzFxb3pNW3kZsYN/ooI4HwaldkAfbKAscEQqja6OrbAQBNYh+2M7y2vVusMakH0Kc0dqRePkvBxkJ0Olj2++4ddAb8LSPcNq1fw+2q3XYkkeNMAn0jYoB+2VJ0ZKgTIBNExs+sEMQn6Y+XzhkY7gooXfUJkwOnbre8xbi5DK45C8v3dQ58SAINfUOwzt8r4M1rfMDWz2VA76zTf1X6+bHPyxqj+itppXlzFdN9TyUjdeNRYxZ/Q/XseCP/eZ91LAyMbNCo7h/Ocnp22i2yohPjRgZxx1zB3O4qtUfwwwCjOony2jQLqWadrxWCHqCmy3kNx/CngqcUGomD1A==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Fri, 27 Jan 2023 12:10:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Henry,
On 27/01/2023 12:15, Henry Wang wrote:
>
>
> Hi Michal,
>
>> -----Original Message-----
>>>>
>>>> - BUG_ON(p2m_teardown(d, false));
>>> Because you remove this,
>>>> ASSERT(page_list_empty(&p2m->pages));
>>> you no longer need this assert, right?
>> I think the ASSERT() is still useful as it at least show that the pages
>> should have been freed before the call to p2m_final_teardown().
>
> I think I also prefer to have this ASSERT(), because of the exactly same
> reason as Julien's answer. I think having this ASSERT() will help us to
> avoid potential mistakes in the future.
>
> May I please ask if you are happy with keeping this ASSERT() and I can
> carry your reviewed-by tag? Thanks!
Yes, you can :)
~Michal
|
