[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 3/3] xen/arm: Clean-up in p2m_init() and p2m_final_teardown()
- To: Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 27 Jan 2023 12:13:29 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wxm2NaW8a7M+SYSIA1DsK65dUhGmuldvYGg8PctsAig=; b=AtMj6M6Ob8mOca0IAmxI6GXKBBYwAQhOpXTnozY1MwAg+AHQSMlXTaCgrCvMyWBdWhNPQXKzHOZscvSoaYB1U+JofjgkHq+tYZXKE7y5PDTmtmd//fZDbczKC3hq2myFqEpzKGh4l/6Kn9HVubkiOHOd7ILDVknHqVxmj20Fu1d2kwlzxgGHXujI04G2dTusXio8D1q00wPx13AstkzuJw6weslg0dycdq75EkxW0Hc9C2Q2gPJVxRIHXe/NXlArn4xVd4ZR98n3FVtt7JlXT3iM9gNN6DliZYPKOMuCLNyhz7DsRRksGrcD2JUf9IwzodiendXiNDwFUfpgU2tznA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PHI66ulJ/oDBPhEdj3f86neOoZ4//KfaIgCiE+tGjc0J3RQHJ+HgMil1XJtxqLNhME1LFY3/m45BHu1ZOQUr3frME8sUx3Gdj+1JFbETqq6uiLATELgvzx5ZoUf5lgF/S+kDL51e6opP8hf0uWuXYmpA0dBscI5uTjwgW4jW9eaykIcp/Y8fqX6cHlstUmPRvNsaj3mhRcSxtAheJdj+604aORUKFb1XVB45vAfd7iqXiThuZ6TtJ9YZ8E5FldKdeXYheazjl0UknZykoLM/dinSL6Vgm33UqJG7Wg+xoDzyr1PYuiSr4owjOTeJIbQ2ViRb15gAqzUsAgnYU5il3A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Fri, 27 Jan 2023 12:13:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZKU4fKh9kG5Xa7kmVEqYgCVpcz66nH76AgAbPKgCABD7DYIAAEFuAgAAAmkA=
- Thread-topic: [PATCH 3/3] xen/arm: Clean-up in p2m_init() and p2m_final_teardown()
Hi Michal,
> -----Original Message-----
> From: Michal Orzel <michal.orzel@xxxxxxx>
> Subject: Re: [PATCH 3/3] xen/arm: Clean-up in p2m_init() and
> p2m_final_teardown()
>
> Hi Henry,
>
> On 27/01/2023 12:15, Henry Wang wrote:
> >
> >
> > Hi Michal,
> >
> >> -----Original Message-----
> >>>>
> >>>> - BUG_ON(p2m_teardown(d, false));
> >>> Because you remove this,
> >>>> ASSERT(page_list_empty(&p2m->pages));
> >>> you no longer need this assert, right?
> >> I think the ASSERT() is still useful as it at least show that the pages
> >> should have been freed before the call to p2m_final_teardown().
> >
> > I think I also prefer to have this ASSERT(), because of the exactly same
> > reason as Julien's answer. I think having this ASSERT() will help us to
> > avoid potential mistakes in the future.
> >
> > May I please ask if you are happy with keeping this ASSERT() and I can
> > carry your reviewed-by tag? Thanks!
> Yes, you can :)
Thank you very much! And also thank you for your detailed review :)
Kind regards,
Henry
>
> ~Michal
|
