[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] xen/common: Constify the parameter of _spin_is_locked()
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Sat, 28 Jan 2023 03:34:29 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OW/rBcIsElCeCi/+9OoWfqxAhGbJ2nZaJF2gZuC1x44=; b=m2rcNmDxslwPbZWPmyrPw6hLLfu7z0s5iRcvNjhgKE+b6cMfiX8EepxXyINRlA1vFYAD78PneqbeLa52MRaEPNqhJ3EZCn+tBmVmVzyZvPyYYYWe6Azpgj2MKZX5RfkeqnRI9t1mL8W8nThlKs56jwZ2OsfEHr1GqNQsog+LTvtvBl64plCHjXKQjmr85QGCbwmuQQo2wzoaFT3DYijrNdGp01PFQdnwwPYiu+Bpac4fMxCO7aIjWoqInT5oImQtXKyc0JgVeSEtz3OTmUYMt+hzQ4HnsaiM/B+Kl0kaq2wyKmP3pKWnd8LlK11s0MheqV1alq1j3xrSif3INKivAQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EDkrG601KRc7pMl3w81H1cZyXLkS7wNz2tbswAtRhvJJMDvwj2Xub6nFWnTNLRwjMLgGnu244ZjMfOXUrN4Icb91mWJdhqZHZYjrats7gJUEH2zWlysg7Yth6gqSy27kYkOTi86Elg3eOK6geeaY6uqrOmYyTSVc8gPRCXilo5fGnS/x3X69h2KyPAbVD5ImHH6iHDWsh4kEaRQinfS7rVo6fk4hK7dRz53K3kXlJ8E6VjlOra7y/Y+x6xPL9miuTl3faqmsWryBbfVrQy/v7M4d2tRyVEFRybkDWl3yKyvI0FbvECq55CALzoD8LVqFZlQ91sqJ3E24ObzCXFii0g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Sat, 28 Jan 2023 03:35:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZMoJm2PD2ghcl7Emq47YXKIuaKq6zEkOw
- Thread-topic: [PATCH] xen/common: Constify the parameter of _spin_is_locked()
Hi Julien,
> -----Original Message-----
> Subject: [PATCH] xen/common: Constify the parameter of _spin_is_locked()
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> The lock is not meant to be modified by _spin_is_locked(). So constify
> it.
>
> This is helpful to be able to assert the locked is taken when the
Nit: s/locked/lock/
This definitely can be fixed on commit.
> underlying structure is const.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
I tried to test this patch on FVP (both Arm32 and Arm64) to play safe.
This patch is good (as expected of course :)), so:
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
Tested-by: Henry Wang <Henry.Wang@xxxxxxx> #Arm
Kind regards,
Henry
|
