[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/common: Constify the parameter of _spin_is_locked()
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 30 Jan 2023 09:11:23 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zYG/MPUoOhkYDW4nIF++KsWNArgHFC3Xi/Ub/Kx07fA=; b=SHw2OjJkxzx4B33KyZDgvUOM4a4I02y/dWd0CiHs1CADDNWxf13VZwvBs6AXScByz76ENXB0NHjqMVOeFX2pmTuZtkWHIpdzqur1e5DexgL4lTgakBQAhcjs9Tiwxf1ECB9XJMR2iTuMPjFkV7aPM3x9gKbPJAAiBXP8uQN52cqEa2oe2YZ+6ecQSv3KlxG4uH7xK19Hqfifl5362esUfYv72yUqQ4ktf1iqu2KO8/ZfO2f8KOlmOAdymI8bKGS1bFvsAGjTEpwwm0opC1nWJeeB1Z6dR27G+9rlEfGLcFpjwJJNawhrncBvBz+8vAresVfYCHSalhi0I4Spa1I/tQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=inXnDK9gWOhxeL3W7EgTIcjJxHtdVmKr0K79BjATXFOFjVTilTI/Gnbpexol2Qg2HyNkCPoEZJLZCwfqKTn+UaRyKZKS5OOK/I775F+CXWbrXChv6Ybr8JrNz1vSawLJLpF8u+KeV7hbLyvItQ6JLcrOtPOxUh//L5HQDn0Fyqw5+Rv+xsXGx7ZyJhx5E0DH5uXBB7SjQ+94OJ31W4tnsrTEzU6KZmuME8dGbtsegdSWTflBRacb0vpNj2Z6jcuB6kZN0NcMmBM0n+znSJDNnBTdTU+8D3ATEs97pafLlHaNGM64EaNT2hB/S/l+sZAY2ZqOD2j/AYKHafP4vL3lEA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 30 Jan 2023 08:11:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.01.2023 20:05, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> The lock is not meant to be modified by _spin_is_locked(). So constify
> it.
>
> This is helpful to be able to assert the locked is taken when the
> underlying structure is const.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
But: Could I talk you into doing the same for _rw_is{,_write}_locked() for
consistency?
Jan
|
