[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/common: Constify the parameter of _spin_is_locked()





On 30/01/2023 08:11, Jan Beulich wrote:
On 27.01.2023 20:05, Julien Grall wrote:
From: Julien Grall <jgrall@xxxxxxxxxx>

The lock is not meant to be modified by _spin_is_locked(). So constify
it.

This is helpful to be able to assert the locked is taken when the
underlying structure is const.

Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

But: Could I talk you into doing the same for _rw_is{,_write}_locked() for
consistency?

Sure. Although, I would prefer to do it in a separate patch.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.