Re: [PATCH v1 2/3] xen/riscv: setup initial pagetables

[Julien Grall <julien@xxxxxxx>]

On 27/02/2023 15:17, Jan Beulich wrote:
> On 25.02.2023 19:05, Julien Grall wrote:
> > On 24/02/2023 15:06, Oleksii Kurochko wrote:
> > > @@ -43,6 +45,11 @@ static void __init disable_fpu(void)
> > >    
> > >    void __init noreturn start_xen(void)
> > >    {
> > > +    unsigned long load_start    = (unsigned long)start;
> > > +    unsigned long load_end      = load_start + (unsigned long)(_end - _start);
> > I am a bit puzzled, on top of load_addr() and linker_addr(), you wrote
> > it can't use global variable/function. But here... you are using them.
> > So how is this different?
> I guess "use" means "access" (i.e. call a function or read/write a
> variable). I suppose it does not mean "take the address of".
If so, then I don't understand why we need to pass linker_start, 
linker_end in parameters for setup_initial_pages().
Cheers,

--
Julien Grall