[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/3] xen/riscv: read/save hart_id and dtb_base passed by bootloader


  • To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 3 Mar 2023 10:27:55 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5X/DTcnwBc7mQG7OWu00/8hBXmNujAiEQl+NyeQ/Tc4=; b=Ih3pc2Le+0odInTYMLlWtLZzLj9djXr4CzqNj2uAVIwKwg5Z21Wc47pS2qkGLjJlOdIpO4KIakGfZLjH91UZu5OthGetYSenKpO/aE3PDTNNZy9imOpyrG+La8wNTN09Zw6g/dw5lSqtHKAdlOTCVyrQgYVU+uRAtl3/Od46hV3Dx4rpTMXZETXWX0UPwNffhQqM9OWgCKNgC8MHKc3eWlo/+dYgvSRrQCIMIq49AAh2EaqlMqxDzwHWIARujbJot5gQ7wZihpYeVyn0svjI9KTznvoW3iQaJSHANkJEkVxDnqL2SGyrLB71OzIsl6b07wrTYP9JcclaUzrVgRWIvA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JExfhdo0ofhkOudpmk2IjaShmkCzk6Z1dkyRmdtwpuZJ/5Iiq6m7JbvwRSyNlGnERekH3I5t2a/3DRa1oVO7OBRHKfDLxokolnRpL36Ri69exSSDBLCxrRedktiomQfLFOOa+xkCdhoO0V0kIPieTMnkCZ4KBV/LuEfmqwvlkqrG1mFRiKRUlfqVNCrqJEl1n8NMm5B6fsYW4yj7FAPgxNJLcrQpz0FrLRFtHQ9vX1Ap+yENgvR/6tZaqy2tw0kEn7wpl7yPaw0zpIIvFCNHGFZfICw+1ikwIfUtTiO/zX5XqC8WdQhUXbcLXLy/68/pvwteeyegIQ2yaVtzhxbxPg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>
  • Delivery-date: Fri, 03 Mar 2023 10:28:14 +0000
  • Ironport-data: A9a23:d/Z/j6K6X8XqeYsoFE+RZJQlxSXFcZb7ZxGr2PjKsXjdYENS3zBUz TYaC2uDPamIZmL1c41yatvnoUJVvcWHmIdhGQVlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA5QRlPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c57WDF/2 6IKNQwwRRubm8es75KwTMVV05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMlGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzHKhAtNJReDQGvhCnWHMgUJMBRwvC0KlrfeS20uQXI54E hlBksYphe1onKCxdfH6WxC7u3+F+B0BQd1bE+49wA6Iw6vQpQ2eAwAsXjNHLdArqsIybTgrz UOS2cPkAyR1t7+YQm7b8a2bxRuwMyUIKW4JZQcfUBAIpdLkpekblQnTR9xuFKq0iNzdGjzqx T2O6i8kiN07gs8C0aGm9lnvmTOyoYPISAVz7QLSNkqv6QlzdYO+Z4il7FHdxflFJYedCFKGu RAsksyf9/wHDIvLmjaERu4MB5m26/3DOzrZ6XZkGJ8n8Dah8mCiZqhf5Th/IAFiNcNsRNPyS ErauAcU6JoNOnKvNPVze9joVJxsyrX8H9P4UPySdsBJfpV6aA6A+mdpeFKU2Gfu1kMrlMnTJ KumTCplNl5CYYwP8dZ8b711PWMDrszm+V7ueA==
  • Ironport-hdrordr: A9a23:8ZGJ4quS7ZXmYzH0iBHaJv8d7skDeNV00zEX/kB9WHVpm62j+/ xG+c5x6faaslkssR0b9+xoWpPhfZqsz/9ICOAqVN/JMTUO01HYT72Kg7GSpgHIKmnT8fNcyL clU4UWMqyVMbGit7eZ3DWF
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 03/03/2023 10:24 am, Oleksii Kurochko wrote:
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, although it
occurs to me...

> diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c
> index 1c87899e8e..d9723fe1c0 100644
> --- a/xen/arch/riscv/setup.c
> +++ b/xen/arch/riscv/setup.c
> @@ -7,7 +7,8 @@
>  unsigned char __initdata cpu0_boot_stack[STACK_SIZE]
>      __aligned(STACK_SIZE);
>  
> -void __init noreturn start_xen(void)
> +void __init noreturn start_xen(unsigned long bootcpu_id,
> +                               unsigned long dtb_base)

dtb_base probably wants renaming to dtb_paddr as the pagetable series is
just about to make it a non-identity mapping between the two address spaces.

Can fix on commit if you're happy with the suggestion?

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.