[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 3/4] xen/arm: switch ARM to use generic implementation of bug.h


  • To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 3 Mar 2023 12:29:42 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X9WVnjJmEBoWDhj4y1rbR/ePeL2Gc/0FK+hN49gA3tU=; b=CryjmEPR6V99isqnLQ50d3bNNeM/Mdwb+c/1gPY+itYNNygrRWDgQ1mUj9IU8GyX+qv6qeSuDyh/DffYXN7kuNPAxKxu3yIUJ0imJkrT5kXRvsAFQix5QChwMDczpUj95C/m/GTUR7mQMg4EFztPNQbAhKPw8bhk+E+7NkpC25V4R2zjjHi+3ZBb8ErrXxK2YVozpsibvM9mSWRKyZq3etYgbIRpjxoQu0/nYbFJC4pVzO1dtsodJTayibXQ//1z8dNSwFeILUnRKFfSA0K8dVR/LDywlVh0ZhogX6WK0oZOMY3pzsbqyYeZ6Bj0a+kmWrc2YPfm+bN3HREPIaY1Dg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D30VfHhLH4VUXsgmVJwIdlYvvZsYYfeVr206s3tyE3yKd0rTi0xoKTTjw1RY9u+2TJh55fM4xWyulzarGkzamqsQ9FfHNVrQxx6/AXQpDRCxtTTGu/XQiVfzyERdko1LNZ/nbKYZhWZvgtuP7mBf8coYg0uoLZ6mC8fv8SffRPKiiyDLBtWUyPNnolaEfqnEGyKxoXbLE923n6g6kzFEx4O0z/XMZ5JGNNAS0YK85PTvKcw5BU6QwM9i9YjO03pllrJcL26K/4dJbXFAWURSnJuWeIkOGjkbSlujLs06E3sprFIbWj3LPsTmBnj3IFlgFXWW4eUsmbQIPfx7vkt60w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Julien Grall <julien@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 03 Mar 2023 11:29:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 03.03.2023 11:38, Oleksii Kurochko wrote:
> The following changes were made:
> * make GENERIC_BUG_FRAME mandatory for ARM
> * As do_bug_frame() returns -EINVAL in case something goes wrong
>   otherwise id of bug frame. Thereby 'if' cases where do_bug_frame() was
>   updated to check if the returned value is less than 0
> * Switch ARM's implementation of bug.h macros to generic one
> 
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> ---
> Changes in V5:
>  * Nothing changed

I'm glad this isn't true, and the change to common/bug.c ...

> ---
>  xen/arch/arm/Kconfig                 |  1 +
>  xen/arch/arm/arm32/traps.c           |  2 +-
>  xen/arch/arm/include/asm/arm32/bug.h |  2 -
>  xen/arch/arm/include/asm/arm64/bug.h |  2 -
>  xen/arch/arm/include/asm/bug.h       | 75 +-------------------------
>  xen/arch/arm/include/asm/traps.h     |  2 -
>  xen/arch/arm/traps.c                 | 81 +---------------------------
>  7 files changed, 4 insertions(+), 161 deletions(-)

... is gone.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.